-
Notifications
You must be signed in to change notification settings - Fork 0
Add notary manifest #1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Overall looks solid, wanted to discuss the following briefly before we merge @saberistic:
- For Dockerfile, would it possibly be better to make the build more multi-stage to reduce the final image size
- Should we be using a specfic version of
gvproxy
to ensure that your build is reproducible and less likely to break due to unexpected changes in dependencies - For
run.sh
should we add a bit more error handling and logging to make troubleshooting easier - Iirc using
sleep infinity
keeps the container running but doesn't provide any way to gracefully shut down or respond to signals: what if we use a while loop instead of sleep infinity
Here's what I was thinking in terms of multi-stage builds:
|
Thanks for awesome review
|
this PR is also related to https://github.com/EternisAI/tlsn/pull/7 |
This PR allows using
enclavectl
to build the tlsn notary docker image appropriate for EKS deployment