Skip to content

[REFACTOR] Enhancements and Code Cleanup #168

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 8 commits into
base: python
Choose a base branch
from
Open

[REFACTOR] Enhancements and Code Cleanup #168

wants to merge 8 commits into from

Conversation

DeekshithSH
Copy link
Contributor

@DeekshithSH DeekshithSH commented Mar 24, 2025 •
edited
Loading

  • Use fork of Pyrogram (fork by KurimuzonAkuma).
  • Show Stream Button when the message contains an audio or video file.
  • Changed import order.
  • Removed unused imports and trailing spaces.
  • Used lazy formatting in logging.
  • Added type hinting.
  • Use Rotating Logs
  • Don't send body for Head Method

EverythingSuckz
EverythingSuckz requested changes Mar 24, 2025
View reviewed changes
Copy link
Owner

@EverythingSuckz EverythingSuckz left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for your contributions. I've found some small issues.

requirements.txt
pyrogram<=2.0.93
python-dotenv<=0.20.0
aiohttp<=3.11.14
kurigram<=2.1.39
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You sure this is a good fork? I mean I've seen some pretty good forks too like hydrogram.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hydrogram is also good, but its last commit was 4 months ago, so I wasn't sure if it's still actively maintained. Kurigram, on the other hand, seems to be receiving regular updates.

Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Alright, I'll look into it 👍

@EverythingSuckz EverythingSuckz added the enhancement New feature or request label Mar 24, 2025
@EverythingSuckz EverythingSuckz changed the title Enhancements and Code Cleanup [REFACTOR] Enhancements and Code Cleanup Mar 24, 2025
@DeekshithSH
Implement Rotating Logs
7327b37 
Use rotating logs to prevent the log file from growing indefinitely and consuming excessive storage.
EverythingSuckz
EverythingSuckz approved these changes Mar 25, 2025
View reviewed changes
Copy link
Owner

@EverythingSuckz EverythingSuckz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!
I'll merge this as soon as I test this code

@EverythingSuckz EverythingSuckz self-requested a review March 25, 2025 00:33
@EverythingSuckz EverythingSuckz added todo todo inspecting Currently looking into this issue labels Mar 25, 2025
@DeekshithSH
Copy link
Contributor Author

any update 🥲

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@EverythingSuckz EverythingSuckz Awaiting requested review from EverythingSuckz

Assignees

No one assigned

Labels

enhancement New feature or request inspecting Currently looking into this issue todo todo

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@DeekshithSH @EverythingSuckz