New terrain wall function #1770
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
marchdf
reviewed
Oct 14, 2025
| m_Cs = std::sqrt(8 * (1 + m_Cb) / (27 * M_PI * M_PI)); | ||
| m_C1 = std::sqrt(960) * m_Cb / (7 * (1 + m_Cb) * m_Sk); | ||
| m_C2 = m_C1; | ||
| pp.query("refMOL", m_refMOL); |
There was a problem hiding this comment.
I like that you renamed this but I am worried about backwards compatability. Can you add an abort if someone tries to use this refMOL? There's a pp is present function you can use.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
The terrain wall-function has been modified to provide wall function capability consistent with the flat terrain. The hybrid version of the Kosovic model has also been modified to be terrain-aware.
Please check the type of change introduced:
Additional background
The existing regression tests and unit tests will be sufficient.
Issue Number: