Skip to content

Conversation

chrismikehogan
Copy link

When a trace is missing a span, we dont know what service is missing, so it is less confusing if we label the service as "unknown" rather than guessing (often incorrectly) that the service's name isthe same as the child span's service name.

When a trace is missing a span, we dont know what service is missing, so it is less confusing if we label the service as "unknown" rather than guessing (often incorrectly) that the service's name isthe same as the child span's service name.
@ayansen
Copy link
Member

ayansen commented Nov 20, 2018

@chrismikehogan This function is used in two cases

  1. if there our multiple root spans found in a trace, our best guess is the root span is the one which has the earliest span - which I think holds true
  2. There are no root spans found, in that case I'd we can set the root span's service name as unknown

so if you update the code to take in an optional autogenerated root span, service name else use the current behaviour, this pr should be good to merge

@ayansen
Copy link
Member

ayansen commented Nov 20, 2018

Also you would need to fix the test cases :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants