fix: Fixed convert chat type in method create_chat #522
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
|
Линтер не проходит тесты |
vladimirgubarik
requested changes
Sep 22, 2025
| values = {"chat_type": ChatTypes.GROUP_CHAT} | ||
| result = BotXAPICreateChatRequestPayload._convert_chat_type(values) # type: ignore[operator] | ||
| assert result["chat_type"] == APIChatTypes.GROUP_CHAT | ||
| result = BotXAPICreateChatRequestPayload._convert_chat_type(ChatTypes.GROUP_CHAT) # type: ignore[operator] |
Contributor
There was a problem hiding this comment.
не совсем понимаю, зачем тестировать проткетед метод модели.
Это создает хрупкие тесты. Если ты станешь валидировать как-то по другому(например в рут валидаторе), то придется переписывать и этот тест.
К тому же, если кто-то вдруг нечаянно уберет декоратор с этого метода модели - тест все равно будет проходить .
Лучше протестировать всю работу создания модели, так будет надежнее.
| assert result == APIChatTypes.CHAT | ||
|
|
||
| # Test with missing chat_type key | ||
| values = {"name": "test"} # type: ignore[dict-item] |
Contributor
There was a problem hiding this comment.
Это рудимент от предыдущей реализации валидатора
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR checklist
pyproject.tomlpybotxinbot-template