Remove react dependency and react features #182
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This is a feature almost no used and should belong to other package. It was causing dependency resolution issues for some consumers and potentially increasing bundle size.
BundleMonNo change in files bundle size Groups updated (1)
Final result: ✅ View report in BundleMon website ➡️ |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related task: https://app.clickup.com/t/869agujx8
The React dependency was causing dependency resolution issues for some projects.
For example, when building a project that uses
d2-app-scriptsand includes@eyeseetea/d2-api,d2-app-scripts buildwould fail with:Found 2 versions of 'react' in yarn.lock: 16.14.0, 18.3.1.These React features are almost no used and in case we want a react adapter in the future, it should belong to other package such as
d2-api-react(while including react as a peerDep).