Skip to content

Conversation

@gqcorneby
Copy link
Contributor

@gqcorneby gqcorneby commented Oct 21, 2025

📌 References

📝 Implementation

  • add UserSettings that is saved consistently in user data store (regardless of selected storage)
  • set user defaults in settings page
  • use user default inclusion modes when creating on demand

📹 Screenshots/Screen capture

2025-10-21.03-38-24.mp4

🔥 Is there anything the reviewer should know to test it?

📑 Others

  • Any change in the GUI library? If so, what branch/PR?

  • Any change in the D2 Api? If so, what branch/PR?

@gqcorneby gqcorneby requested a review from MiquelAdell October 21, 2025 04:32
@bundlemon
Copy link

bundlemon bot commented Oct 21, 2025

BundleMon

No change in files bundle size

Groups updated (1)
Status Path Size Limits
Build Folder
./**/*
2.78MB (+1.21KB +0.04%) +20%

Final result: ✅

View report in BundleMon website ➡️


Current branch size history | Target branch size history

@gqcorneby
Copy link
Contributor Author

Workflow failures are fixed here: #1035

@MiquelAdell
Copy link
Contributor

Once the defaults are set I can not change them. I tried that in dev.est and in a play instance with a fresh install:

Screen.Recording.2025-10-21.at.08.55.39.mov

@gqcorneby
Copy link
Contributor Author

Hi @MiquelAdell! Sorry about that! Should be fixed now

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants