fix: Launching Ruffle on macOS #476
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When Ruffle is downloaded by the launcher on macOS, it is downloaded as an application rather than a standalone binary. This results in the launcher being unable to launch Ruffle, as it expects to find it in `ruffle` instead of its actual location (`Ruffle.app/Contents/MacOS/ruffle`), relative to `Data/Ruffle/standalone/latest`. This PR corrects that behavior, allowing the launcher to automatically set the proper permissions and launch Ruffle on macOS like it can on Linux.
Maoijoon
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When Ruffle is downloaded by the launcher on macOS, it is downloaded as an application rather than a standalone binary. This results in the launcher being unable to launch Ruffle, as it expects to find it in
ruffleinstead of its actual location (Ruffle.app/Contents/MacOS/ruffle), relative toData/Ruffle/standalone/latest. This PR corrects that behavior, allowing the launcher to automatically set the proper permissions and launch Ruffle on macOS like it can on Linux.