Rename 'collection' to 'items' in README #53
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The Neos 9 compatibility release contained an undocumented breaking change of the `Flowpack.Listable:Collection` prototype. The collections property changed from `collection` to `items`.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The Neos 9 compatibility release contained an undocumented breaking change of the
Flowpack.Listable:Collectionprototype. The collections property changed fromcollectiontoitems.I was contemplating if it would be better to rename it back, to be more in line with the other prototypes. However this would introduce another breaking change, which is why I decided to only document the behavior for now.
Let me know what you think and if I should make any changes to my PR :)