Skip to content

TASK: change button style of AssetAction buttons too neutral #199

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 4 commits into
base: main
Choose a base branch
from
Open

TASK: change button style of AssetAction buttons too neutral #199

Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
7bf67f1
TASK: change button style of AssetAction buttons too neutral
crydotsnake Aug 4, 2023
1b9ae6b
TASK: adjust button style according to current list mode
crydotsnake Aug 18, 2023
edc5041
TASK: remove unused setViewModeSelection declaration
crydotsnake Aug 18, 2023
83fddaa
TASK: use long spelling of ternary operator
crydotsnake Aug 18, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
19 changes: 13 additions & 6 deletions Resources/Private/JavaScript/media-module/src/components/Main/AssetActions.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,12 +1,13 @@
import React, { useCallback } from 'react';
import { useSetRecoilState, useRecoilState } from 'recoil';
import { useRecoilState, useSetRecoilState } from 'recoil';

import { IconButton } from '@neos-project/react-ui-components';

import { useIntl, useMediaUi, useNotify } from '@media-ui/core';
import { useDeleteAsset, useImportAsset } from '@media-ui/core/src/hooks';
import { selectedAssetForPreviewState } from '@media-ui/feature-asset-preview';
import { clipboardItemState } from '@media-ui/feature-clipboard';
import { VIEW_MODES, viewModeState } from '../../state';

interface ItemActionsProps {
asset: Asset;
Expand All @@ -22,6 +23,7 @@ const AssetActions: React.FC<ItemActionsProps> = ({ asset }: ItemActionsProps) =
const [isInClipboard, toggleClipboardState] = useRecoilState(
clipboardItemState({ assetId: asset.id, assetSourceId: asset.assetSource.id })
);
const [viewModeSelection] = useRecoilState(viewModeState);

// TODO: Optimize rendering this component when hooks change, as it takes quite a bit of time
const onImportAsset = useCallback(() => {
Expand Down Expand Up @@ -68,7 +70,7 @@ const AssetActions: React.FC<ItemActionsProps> = ({ asset }: ItemActionsProps) =
title={translate('itemActions.preview', 'Preview asset')}
icon="expand-alt"
size="regular"
style="transparent"
style={viewModeSelection === VIEW_MODES.List ? 'transparent' : 'neutral'}
hoverStyle="brand"
onClick={() => setSelectedAssetForPreview({ assetId: asset.id, assetSourceId: asset.assetSource.id })}
/>
Expand All @@ -77,7 +79,7 @@ const AssetActions: React.FC<ItemActionsProps> = ({ asset }: ItemActionsProps) =
title={translate('itemActions.import', 'Import asset')}
icon="cloud-download-alt"
size="regular"
style="transparent"
style={viewModeSelection === VIEW_MODES.List ? 'transparent' : 'neutral'}
hoverStyle="brand"
onClick={onImportAsset}
/>
Expand All @@ -92,22 +94,27 @@ const AssetActions: React.FC<ItemActionsProps> = ({ asset }: ItemActionsProps) =
disabled={asset.isInUse}
icon="trash"
size="regular"
style="transparent"
style={viewModeSelection === VIEW_MODES.List ? 'transparent' : 'neutral'}
hoverStyle="error"
onClick={() => onDeleteAsset(asset)}
/>
)}
{asset.file?.url && (
<a href={asset.file.url} download title={translate('itemActions.download', 'Download asset')}>
<IconButton icon="download" size="regular" style="transparent" hoverStyle="success" />
<IconButton
icon="download"
size="regular"
style={viewModeSelection === VIEW_MODES.List ? 'transparent' : 'neutral'}
hoverStyle="success"
/>
</a>
)}
{asset.localId && (
<IconButton
title={translate('itemActions.copyToClipboard', 'Copy to clipboard')}
icon={isInClipboard ? 'clipboard-check' : 'clipboard'}
size="regular"
style="transparent"
style={viewModeSelection === VIEW_MODES.List ? 'transparent' : 'neutral'}
hoverStyle="brand"
className={isInClipboard ? 'button--active' : ''}
onClick={toggleClipboardState}
Expand Down