BUGFIX: Add bottom margin for thumbnail view so it doesn't overlap with pagination in link editor/media selection view #258
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thx, but do you have some hints on your browser and resolution you used, as I cannot reproduce the issue (and fixed it already sometime in the past) |
…th pagination in link editor/media selection view
gradinarufelix
force-pushed
the
bugfix-add-margin-to-thumbnail-view
branch
from
1cb086f to
6f10956
Compare
|
I just checked it again. This happens in combination with https://github.com/sitegeist/Sitegeist.Archaeopteryx when you want to create a link and switch to the "media" tab. |
Sebobo
requested changes
Sep 26, 2025
| display: grid; | ||
| grid-template-columns: repeat(auto-fill, minmax(200px, 1fr)); | ||
| gap: var(--theme-spacing-Full); | ||
| margin-bottom: 4rem; |
There was a problem hiding this comment.
I think the correct place is adding padding-bottom: 41px; when in selectionMode. As the calculation for the height doesn't correctly measure the available size.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What I did
I added 4rem of margin-bottom to ThumbnailView, because in a selection view the last line of filenames was not readable due to it being hidden behind the pagination.
How I did it
I added 4rem of margin-bottom to ThumbnailView.module.css.