Skip to content

Conversation

ThibautVerron
Copy link
Contributor

Hi,

This is a pull request for the code related to the generic string delimiters ( #1039 ). You might want to squash the history, the last commits were very messy (sorry about that).

It turns out that this:

As it is, it might be slightly breaking for ruby users, for example sp-backward-sexp with %w(asd)| will now move the point to before %, not before the opening paren.

is no longer a problem.

But on the other hand, I don't know how to do it again if we were to decide that it is the wanted behaviour. Something seems to be overriding the detection of the string somewhere in sp-get-expression.

Emacs' default sexp navigation (using syntax tables) correctly navigates to the beginning of the string in the same scenario.

Thanks for your work ! :)

@ThibautVerron
Copy link
Contributor Author

You might want to squash the history, the last commits were very messy (sorry about that).

Or should I do it and offer to merge a clean branch?

@Fuco1
Copy link
Owner

Fuco1 commented Oct 19, 2020

No problem with the squash, GitHub can do it automatically when merging. Thank you for the PR, I'll review it shortly.

@Fuco1 Fuco1 self-assigned this Oct 19, 2020
@Fuco1 Fuco1 self-requested a review October 19, 2020 20:55
@Fuco1 Fuco1 removed their assignment Oct 19, 2020
@ThibautVerron
Copy link
Contributor Author

Ping? :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Status: In review
Development

Successfully merging this pull request may close these issues.

2 participants