Feature/dwim kill region #873
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fuco1
commented
Mar 16, 2018
| (interactive "r") | ||
| (when (or current-prefix-arg | ||
| (sp-region-ok-p beg end) | ||
| (-let [(&plist :ok ok :last-good-sexp last-good-sexp) (sp-get-region-info beg end)] |
There was a problem hiding this comment.
We should extract this new block into a separate function as it will be reused multiple times
Fuco1
commented
Mar 16, 2018
|
|
||
| (cl-defun sp-region-ok-p (start end) | ||
| "Test if region between START and END is balanced. | ||
| (defun sp-get-region-info (start end) |
There was a problem hiding this comment.
Document this somewhere (check if region-ok-p was documented)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related to #867