(parallel-executor): Skeleton & Block production #2976
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@xgreenx I would like to know if you had something in mind for managing all the worker threads. I usually like to go with creating OS threads but I know that you often prefer the tokio runtime with multiple tasks. But compare to the first version this one is fetching batch of txs multiple times and we admitted during the design that the states belong to one worker which is not possible to isolate like that with tokio |
rymnc
previously approved these changes
Jun 30, 2025
## Linked Issues/PRs <!-- List of related issues/PRs --> closes #2928 ## Description Removes the `#[ignore]` and fixes `latest_state_transition_function_is_forward_compatible_with_v44_binary` - Add a new `chain-configurations` entry for `v44` - Copy over the contents of the previous version - Update `latest_state_transition_function_is_forward_compatible_with_v44_binary` to use the new `chain-configurations/` directory - Create a new const: `pub const V44_TESTNET_SNAPSHOT: &str = "./chain-configurations/v44";` - Update the test to use the new const - Update the STF version to match native for `v44` (`28`) - "genesis_state_transition_version" in `chain_config.json` - "state_transition_version" for the `latest_block` in `state_config.json` - Bump the versions in the test asserts to`29` and `30` respectively.
|
Thanks for the contribution! Before we can merge this, we need @AurelienFT to sign the Fuel Labs Contributor License Agreement. |
## Linked Issues/PRs <!-- List of related issues/PRs --> ## Description <!-- List of detailed changes --> This in practice ended up being as much of an integration tests as a benchmark. There were a few places that weren't plugged in that needed finessing before this would run properly. ~In addition, this uses the `u32-tx-pointer` feature from `fuel-tx`. This is a **_BREAKING_** change as the header has changed.~ ~If we don't want to contaminate the code with a breaking change for the benchmark, then we can hide that behind a new feature flag on the `fuel-types` library.~ I've introduced a `u32-tx-count` feature that changes a lot of `u16` to `u32` for tx pointers as well as tx count in header etc. This prevents this code from being breaking. ## Checklist - [ ] New behavior is reflected in tests - [ ] [The specification](https://github.com/FuelLabs/fuel-specs/) matches the implemented behavior (link update PR if changes are needed) ### Before requesting review - [x] I have reviewed the code myself - [ ] I have created follow-up issues caused by this PR and linked them here
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Linked Issues/PRs
Part of #2952
Description
Describe in #2952
Everything commented in scheduler.rs
Checklist
Before requesting review
After merging, notify other teams
[Add or remove entries as needed]