Skip to content

Conversation

@FuroYT
Copy link

@FuroYT FuroYT commented Sep 30, 2025

Description

Fixes the issue that MathUtil::smoothLerpPrecision and MathUtil::smoothLerpDecay could be fps dependant sometimes.
This makes these function really adapt to deltaTime so they show up the same in every framerate

@github-actions github-actions bot added status: pending triage Awaiting review. size: medium A medium pull request with 100 or fewer changes. pr: haxe PR modifies game code. labels Sep 30, 2025
@Hundrec Hundrec added the type: minor bug Involves a minor bug or issue. label Sep 30, 2025
@Hundrec Hundrec changed the title [BUGFIX] Fix MathUtil Lerp Functions [BUGFIX] Make MathUtil Lerp Functions not FPS-dependent Sep 30, 2025
@Hundrec
Copy link
Member

Hundrec commented Sep 30, 2025

This might be the one that does it

@trayfellow
Copy link

Chat is this true

@DustedDustin
Copy link

this fixes the lerping being strange for scoring at high framerates? (I assume it does for other lerping issues, but that was the one I noticed the most when playing at 500fps and the score not smoothly lerping)

@cyn0x8
Copy link
Contributor

cyn0x8 commented Oct 7, 2025

unfortunately, i think this pr (or at least the MathUtil change) is redundant
the current functions are already framerate independent

testing both the existing functions and the ones from this pr with different framerates (plus some random varying deltas just to make sure) doesnt show any real difference

image

they all still correctly converge to the function path with higher framerates, but the changed functions just do it in extra steps

image

@FuroYT
Copy link
Author

FuroYT commented Oct 7, 2025

unfortunately, i think this pr is redundant

the current functions are already framerate independent

testing both the existing functions and the ones from this pr with different framerates (plus some random varying deltas just to make sure) doesnt show any real difference

image

they all still correctly converge to the function path with higher framerates, but this pr just does it in extra steps

image

I've had multiple times where the function ran without fps independance and it wasn't that rare and I since don't have the problem

@cyn0x8
Copy link
Contributor

cyn0x8 commented Oct 7, 2025

I've had multiple times where the function ran without fps independance and it wasn't that rare and I since don't have the problem

wherever this is occurring, im confident the issue lies in the implementation and not the lerp functions themselves then

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

pr: haxe PR modifies game code. size: medium A medium pull request with 100 or fewer changes. status: pending triage Awaiting review. type: minor bug Involves a minor bug or issue.

Development

Successfully merging this pull request may close these issues.

5 participants