[ENHANCEMENT/FIX] Sort notes by length #6240
Draft
+50
−49
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Linked Issues
Couldn't find any, but there could be.
Description
After the sustain notes rework, note hits just play the sing animation once, so if there is a double note, one with length 0 and another one being sustained, depending on the note list sorting for automatic characters or hit time for players, it can look weird to just sing the short note instead of the long one.
Another thing that I would want to do for this PR is also fixing it for player controlled characters.
Create some kind of
lastHitNoteDatain the character that holds the data of the last note hit, and then, after hitting a note, check if the last note hit has the same strumTime, and if the length of the last note hit is bigger than the current one, don't play the sing animation.I wasn't sure of adding it because I don't really know if intended or not, any developer please let me know =)
Screenshots/Videos
Before (the chart has to be done WITHOUT the fix, also you need to add the short note AFTER the long ones)
Recording.2025-10-08.223052.mp4
After, with the same chart
after.mp4