Skip to content

Conversation

@gamerbross
Copy link
Contributor

@gamerbross gamerbross commented Oct 8, 2025

Linked Issues

Couldn't find any, but there could be.

Description

After the sustain notes rework, note hits just play the sing animation once, so if there is a double note, one with length 0 and another one being sustained, depending on the note list sorting for automatic characters or hit time for players, it can look weird to just sing the short note instead of the long one.

Another thing that I would want to do for this PR is also fixing it for player controlled characters.
Create some kind of lastHitNoteData in the character that holds the data of the last note hit, and then, after hitting a note, check if the last note hit has the same strumTime, and if the length of the last note hit is bigger than the current one, don't play the sing animation.

I wasn't sure of adding it because I don't really know if intended or not, any developer please let me know =)

Screenshots/Videos

Before (the chart has to be done WITHOUT the fix, also you need to add the short note AFTER the long ones)

Recording.2025-10-08.223052.mp4

After, with the same chart

after.mp4

@github-actions github-actions bot added status: pending triage Awaiting review. size: medium A medium pull request with 100 or fewer changes. pr: haxe PR modifies game code. labels Oct 8, 2025
@gamerbross gamerbross marked this pull request as draft October 8, 2025 23:21
{
if (a == null || b == null) return 0;
return noteDataByTime(order, a.noteData, b.noteData);
}
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Probably keep byStrumtime so this PR won't be a breaking change for some people.

Suggested change
}
}
@:deprecated("Use notebyStrumtime() instead")
public static function byStrumtime(order:Int, a:NoteSprite, b:NoteSprite):Void
{
notebyStrumtime(order, a, b);
}

@AbnormalPoof AbnormalPoof added the type: enhancement Involves an enhancement or new feature. label Oct 10, 2025
@Hundrec Hundrec added status: needs revision Cannot be approved because it is awaiting some work by the contributor. and removed status: pending triage Awaiting review. labels Oct 14, 2025
@Hundrec Hundrec changed the base branch from dummy/develop-v0.7.5 to develop October 19, 2025 23:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

pr: haxe PR modifies game code. size: medium A medium pull request with 100 or fewer changes. status: needs revision Cannot be approved because it is awaiting some work by the contributor. type: enhancement Involves an enhancement or new feature.

Development

Successfully merging this pull request may close these issues.

4 participants