Add time signature changes + fixed BPM changes to Monster #281
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
status: pending triage
qt2k4
changed the title
|
this pr doesn't make any changes to the actual chart if that's what you're getting at. just the metadata |
|
Yeah figured out so, yeah, but we'll see how Hundrec reacts to this. |
Hundrec
added
status: pending triage
Hundrec
added
type: charting issue
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Linked Issues
Fixes FunkinCrew/Funkin#5256
Description
This PR adds time signature changes to Monster's metadata, along with removing any unnecessary BPM changes and adjusting the remaining ones so that everything's lined up properly.
The camera bops still go out of sync due to the different time signatures, but the Offset feature added to the Set Camera Bop event in 0.7.4 should make that an easy fix.
Note that most of the chart is still offset from the grid by a few milliseconds, even with the above fixes. I don't think it's possible to get the timing better than this, but I could be wrong.
Screenshots/Videos
monster.timechange.demo.a.mp4
monster.timechange.demo.b.mp4
(ignore the misalignments in the second video. Monster has a ton of misaligned notes currently)