-
Notifications
You must be signed in to change notification settings - Fork 26
Merge wied03/ENG-2158/change-password #171
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from all commits
Commits
Show all changes
3 commits
Select commit
Hold shift + click to select a range
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
34 changes: 34 additions & 0 deletions
34
src/main/api/checkChangePasswordUsingLoginIdAndLoginIdTypes.json
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,34 @@ | ||
| { | ||
| "uri": "/api/user/change-password", | ||
| "comments": [ | ||
| "Check to see if the user must obtain a Trust Request Id in order to complete a change password request.", | ||
| "When a user has enabled Two-Factor authentication, before you are allowed to use the Change Password API to change", | ||
| "your password, you must obtain a Trust Request Id by completing a Two-Factor Step-Up authentication.", | ||
| "", | ||
| "An HTTP status code of 400 with a general error code of [TrustTokenRequired] indicates that a Trust Token is required to make a POST request to this API." | ||
| ], | ||
| "method": "get", | ||
| "methodName": "checkChangePasswordUsingLoginIdAndLoginIdTypes", | ||
| "successResponse": "Void", | ||
| "errorResponse": "Errors", | ||
| "params": [ | ||
| { | ||
| "name": "loginId", | ||
| "comments": [ | ||
| "The loginId of the User that you intend to change the password for." | ||
| ], | ||
| "type": "urlParameter", | ||
| "parameterName": "loginId", | ||
| "javaType": "String" | ||
| }, | ||
| { | ||
| "name": "loginIdTypes", | ||
| "comments": [ | ||
| "The identity types that FusionAuth will compare the loginId to." | ||
| ], | ||
| "type": "urlParameter", | ||
| "parameterName": "loginIdTypes", | ||
| "javaType": "List<String>" | ||
| } | ||
| ] | ||
| } |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We didn't have anything using this particular API endpoint so this was not noticed but the parameter name was wrong. The action does not have a
usernamefield, only aloginIdfield.The difference is noticeable in the java client https://github.com/FusionAuth/fusionauth-java-client/pull/144/files#diff-907b0157ed4d05913f38430e58f3513c6262bf0f51eb14b81ad41a190d8af575R547
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
So this client method wouldn't have worked before?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
That's right. It would not have. We don't consume it ourselves so that's 1 reason we didn't notice.