Skip to content

Conversation

@jobannon
Copy link
Contributor

@jobannon jobannon commented Oct 3, 2025

No description provided.

@jobannon jobannon requested review from a team as code owners October 3, 2025 23:17
Comment on lines 148 to 151
**OAuth Logout Endpoint and the id_token_hint**

Now that we are identifying an `id_token` using the newly added `tty` claim, we are now correctly rejecting an `access_token` when used as the `id_token_hint` parameter (this aligns with the OAuth spec). If you had previously built an integration to send an `access_token` as the `id_token_hint` parameter instead of the `id_token` you will need to correct your integration before upgrading to this version.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Now that we are identifying an id_token using the newly added tty claim, the OAuth2 Logout endpoint will now correctly reject an access_token when sent as the id_token_hint parameter according to spec. If you have any integrations that are sending an access_token in the id_token_hint parameter instead of the id_token you will need to correct your integration prior to upgrading.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice, fixed up

robotdan
robotdan previously approved these changes Oct 23, 2025
Copy link
Member

@robotdan robotdan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good. I left one more comment for the heading - let's keep that short to match the other headings in this section.

parameter (this aligns with the OAuth spec).

IMO using parens is not great, this feels like an aside. Maybe better to just drop this since we already are saying we are now correctly rejecting this parameter and just say:

when used as the id_token_hint parameter.

And I think it is redundant to say to this version since this is part of the release notes for this version.

your integration before upgrading to this version.

Ensure you have reviewed the copy suggested in these comments:

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants