Skip to content

Update to match GEOSgcm main as of 2024-Aug-20 #50

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Draft
wants to merge 6 commits into
base: main
Choose a base branch
from
Draft

Update to match GEOSgcm main as of 2024-Aug-20 #50

wants to merge 6 commits into from

Conversation

@mathomp4
Copy link
Member

This is mainly an exploratory test. I want to make sure GEOSctm works with the latest CircleCI orb. But to do that, I need to update everything to match roughly what is in GEOSgcm at this moment. So...here we go.

Labeling non-zero-diff because I'm guessing it is. Not sure, but the components.yaml is so changed, I have to imagine something in there makes it non-zero-diff!

@mathomp4 mathomp4 added the Non 0-diff The changes in this pull request are non-zero-diff label Aug 20, 2024
@mathomp4 mathomp4 self-assigned this Aug 20, 2024
@mathomp4
Copy link
Member Author

Welp, I have reached "I don't know what I'm doing" level of CTM. My guess is something must need to change in the CTM somewhere to work with components on the scale of GEOSgcm v11? Only @mmanyin would know:

[ 79%] Building Fortran object src/Components/GEOSctm_GridComp/@GEOSchem_GridComp/CMakeFiles/GEOSchem_GridComp.dir/GEOS_ChemGridComp.F90.o
/discover/swdev/mathomp4/Models/GEOSctm-UpdatetoGCM/src/Components/GEOSctm_GridComp/@GEOSchem_GridComp/GEOS_ChemGridComp.F90(23): error #7002: Error in opening the compiled module file.  Check INCLUDE paths.   [GOCART2G_GRIDCOMPMOD]
  use     GOCART2G_GridCompMod,  only : GOCART2G_SetServices  => SetServices !GOCART REFACTOR
----------^
/discover/swdev/mathomp4/Models/GEOSctm-UpdatetoGCM/src/Components/GEOSctm_GridComp/@GEOSchem_GridComp/GEOS_ChemGridComp.F90(24): error #7002: Error in opening the compiled module file.  Check INCLUDE paths.   [STRATCHEM_GRIDCOMPMOD]
  use    StratChem_GridCompMod,  only : StratChem_SetServices => SetServices
---------^
/discover/swdev/mathomp4/Models/GEOSctm-UpdatetoGCM/src/Components/GEOSctm_GridComp/@GEOSchem_GridComp/GEOS_ChemGridComp.F90(25): error #7002: Error in opening the compiled module file.  Check INCLUDE paths.   [GMICHEM_GRIDCOMPMOD]
  use      GMIchem_GridCompMod,  only :       GMI_SetServices => SetServices
-----------^
/discover/swdev/mathomp4/Models/GEOSctm-UpdatetoGCM/src/Components/GEOSctm_GridComp/@GEOSchem_GridComp/GEOS_ChemGridComp.F90(34): error #7002: Error in opening the compiled module file.  Check INCLUDE paths.   [TR_GRIDCOMPMOD]
  use           TR_GridCompMod,  only :        TR_SetServices => SetServices
----------------^
/discover/swdev/mathomp4/Models/GEOSctm-UpdatetoGCM/src/Components/GEOSctm_GridComp/@GEOSchem_GridComp/GEOS_ChemGridComp.F90(23): error #6581: Unresolved rename.   [GOCART2G_SETSERVICES]
  use     GOCART2G_GridCompMod,  only : GOCART2G_SetServices  => SetServices !GOCART REFACTOR
----------------------------------------^
/discover/swdev/mathomp4/Models/GEOSctm-UpdatetoGCM/src/Components/GEOSctm_GridComp/@GEOSchem_GridComp/GEOS_ChemGridComp.F90(24): error #6581: Unresolved rename.   [STRATCHEM_SETSERVICES]
  use    StratChem_GridCompMod,  only : StratChem_SetServices => SetServices
----------------------------------------^
/discover/swdev/mathomp4/Models/GEOSctm-UpdatetoGCM/src/Components/GEOSctm_GridComp/@GEOSchem_GridComp/GEOS_ChemGridComp.F90(25): error #6581: Unresolved rename.   [GMI_SETSERVICES]
  use      GMIchem_GridCompMod,  only :       GMI_SetServices => SetServices
----------------------------------------------^
/discover/swdev/mathomp4/Models/GEOSctm-UpdatetoGCM/src/Components/GEOSctm_GridComp/@GEOSchem_GridComp/GEOS_ChemGridComp.F90(34): error #6581: Unresolved rename.   [TR_SETSERVICES]
  use           TR_GridCompMod,  only :        TR_SetServices => SetServices
-----------------------------------------------^
/discover/swdev/mathomp4/Models/GEOSctm-UpdatetoGCM/src/Components/GEOSctm_GridComp/@GEOSchem_GridComp/GEOS_ChemGridComp.F90(256): error #6498: The use-name for this local-name is not defined.   [GOCART2G_SETSERVICES]
    if (myState%enable_GOCART2G  )    GOCART2G = MAPL_AddChild(GC, NAME=    'GOCART2G', SS=GOCART2G_SetServices,  RC=STATUS); if(MAPL_Verify(STATUS,"GEOS_ChemGridComp.F90",256 ,rc)) return
-------------------------------------------------------------------------------------------^
/discover/swdev/mathomp4/Models/GEOSctm-UpdatetoGCM/src/Components/GEOSctm_GridComp/@GEOSchem_GridComp/GEOS_ChemGridComp.F90(256): error #6635: This actual argument must be the name of a procedure and not a data object.   [GOCART2G_SETSERVICES]
    if (myState%enable_GOCART2G  )    GOCART2G = MAPL_AddChild(GC, NAME=    'GOCART2G', SS=GOCART2G_SetServices,  RC=STATUS); if(MAPL_Verify(STATUS,"GEOS_ChemGridComp.F90",256 ,rc)) return
-------------------------------------------------------------------------------------------^
/discover/swdev/mathomp4/Models/GEOSctm-UpdatetoGCM/src/Components/GEOSctm_GridComp/@GEOSchem_GridComp/GEOS_ChemGridComp.F90(259): error #6498: The use-name for this local-name is not defined.   [STRATCHEM_SETSERVICES]
    if (myState%enable_STRATCHEM )   STRATCHEM = MAPL_AddChild(GC, NAME=   'STRATCHEM', SS=StratChem_SetServices, RC=STATUS); if(MAPL_Verify(STATUS,"GEOS_ChemGridComp.F90",259 ,rc)) return
-------------------------------------------------------------------------------------------^
/discover/swdev/mathomp4/Models/GEOSctm-UpdatetoGCM/src/Components/GEOSctm_GridComp/@GEOSchem_GridComp/GEOS_ChemGridComp.F90(259): error #6635: This actual argument must be the name of a procedure and not a data object.   [STRATCHEM_SETSERVICES]
    if (myState%enable_STRATCHEM )   STRATCHEM = MAPL_AddChild(GC, NAME=   'STRATCHEM', SS=StratChem_SetServices, RC=STATUS); if(MAPL_Verify(STATUS,"GEOS_ChemGridComp.F90",259 ,rc)) return
-------------------------------------------------------------------------------------------^
/discover/swdev/mathomp4/Models/GEOSctm-UpdatetoGCM/src/Components/GEOSctm_GridComp/@GEOSchem_GridComp/GEOS_ChemGridComp.F90(260): error #6498: The use-name for this local-name is not defined.   [GMI_SETSERVICES]
    if (myState%enable_GMICHEM   )     GMICHEM = MAPL_AddChild(GC, NAME=     'GMICHEM', SS=GMI_SetServices,       RC=STATUS); if(MAPL_Verify(STATUS,"GEOS_ChemGridComp.F90",260 ,rc)) return
-------------------------------------------------------------------------------------------^
/discover/swdev/mathomp4/Models/GEOSctm-UpdatetoGCM/src/Components/GEOSctm_GridComp/@GEOSchem_GridComp/GEOS_ChemGridComp.F90(260): error #6635: This actual argument must be the name of a procedure and not a data object.   [GMI_SETSERVICES]
    if (myState%enable_GMICHEM   )     GMICHEM = MAPL_AddChild(GC, NAME=     'GMICHEM', SS=GMI_SetServices,       RC=STATUS); if(MAPL_Verify(STATUS,"GEOS_ChemGridComp.F90",260 ,rc)) return
-------------------------------------------------------------------------------------------^
/discover/swdev/mathomp4/Models/GEOSctm-UpdatetoGCM/src/Components/GEOSctm_GridComp/@GEOSchem_GridComp/GEOS_ChemGridComp.F90(266): error #6498: The use-name for this local-name is not defined.   [TR_SETSERVICES]
    if (myState%enable_TR        )          TR = MAPL_AddChild(GC, NAME=          'TR', SS=TR_SetServices,        RC=STATUS); if(MAPL_Verify(STATUS,"GEOS_ChemGridComp.F90",266 ,rc)) return
-------------------------------------------------------------------------------------------^
/discover/swdev/mathomp4/Models/GEOSctm-UpdatetoGCM/src/Components/GEOSctm_GridComp/@GEOSchem_GridComp/GEOS_ChemGridComp.F90(266): error #6635: This actual argument must be the name of a procedure and not a data object.   [TR_SETSERVICES]
    if (myState%enable_TR        )          TR = MAPL_AddChild(GC, NAME=          'TR', SS=TR_SetServices,        RC=STATUS); if(MAPL_Verify(STATUS,"GEOS_ChemGridComp.F90",266 ,rc)) return
-------------------------------------------------------------------------------------------^
compilation aborted for /discover/swdev/mathomp4/Models/GEOSctm-UpdatetoGCM/src/Components/GEOSctm_GridComp/@GEOSchem_GridComp/GEOS_ChemGridComp.F90 (code 1)
make[2]: *** [src/Components/GEOSctm_GridComp/@GEOSchem_GridComp/CMakeFiles/GEOSchem_GridComp.dir/build.make:79: src/Components/GEOSctm_GridComp/@GEOSchem_GridComp/CMakeFiles/GEOSchem_GridComp.dir/GEOS_ChemGridComp.F90.o] Error 1
make[1]: *** [CMakeFiles/Makefile2:9838: src/Components/GEOSctm_GridComp/@GEOSchem_GridComp/CMakeFiles/GEOSchem_GridComp.dir/all] Error 2
make: *** [Makefile:166: all] Error 2

Still, CI worked as far as it did.

@mmanyin
Copy link
Contributor

mmanyin commented Aug 20, 2024

@mathomp4 - A valiant effort! We know that GOCART-2G poses some difficulty in CTM. Before tackling that, we want to address an issue with Advection in the existing version. Please keep this branch, since it points the way for env, cmake, etc. We will come back to it and work on GOCART-2G, hopefully in the next few months.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

@mathomp4 mathomp4

Labels

Non 0-diff The changes in this pull request are non-zero-diff

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@mathomp4 @mmanyin