Skip to content

Mark test_binstats_quantile as xfail in the GMT Legacy Tests workflow #4087

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 6 commits into from
Sep 16, 2025
Merged

Mark test_binstats_quantile as xfail in the GMT Legacy Tests workflow #4087

Changes from all commits
Commits
Show all changes
6 commits
Select commit Hold shift + click to select a range
cdc8b25
Try using skipna=True in min() for test_binstats_quantile
weiji14 Sep 15, 2025
b37898b
Temporarily trigger ci_tests_legacy
weiji14 Sep 15, 2025
dd5abb4
Specify different min/median/mean values for GMT 6.4
weiji14 Sep 15, 2025
3df87bb
Merge branch 'main' into fix_test_binstats_quantile
weiji14 Sep 16, 2025
1dc2e42
Mark test_binstats_quantile as xfail on GMT<6.5
weiji14 Sep 16, 2025
bf228bd
Revert "Temporarily trigger ci_tests_legacy"
weiji14 Sep 16, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 8 additions & 0 deletions pygmt/tests/test_binstats.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -6,7 +6,9 @@

import numpy.testing as npt
import pytest
from packaging.version import Version
from pygmt import binstats
from pygmt.clib import __gmt_version__
from pygmt.enums import GridRegistration, GridType
from pygmt.helpers import GMTTempFile

Expand Down Expand Up @@ -51,6 +53,11 @@ def test_binstats_no_outgrid():
npt.assert_allclose(temp_grid.mean(), 4227489)


# TODO(GMT>=6.5.0): Remove the xfail marker for the upstream bug fixed in GMT 6.5.0.
@pytest.mark.xfail(
condition=Version(__gmt_version__) < Version("6.5.0"),
reason="Upstream bug fixed in https://github.com/GenericMappingTools/gmt/pull/8243",
)
def test_binstats_quantile():
"""
Test binstats quantile statistic functionality.
Expand All @@ -67,6 +74,7 @@ def test_binstats_quantile():
assert temp_grid.dims == ("y", "x")
assert temp_grid.gmt.gtype is GridType.CARTESIAN
assert temp_grid.gmt.registration is GridRegistration.GRIDLINE
assert temp_grid.dtype == "float32"
npt.assert_allclose(temp_grid.max(), 15047685)
npt.assert_allclose(temp_grid.min(), 53)
npt.assert_allclose(temp_grid.median(), 543664.5)
Expand Down
Loading