CI: Migrate the welcome bot to GitHub Actions #4149
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Co-authored-by: Yvonne Fröhlich <[email protected]>
weiji14
approved these changes
Oct 14, 2025
Member
weiji14
left a comment
weiji14
left a comment
There was a problem hiding this comment.
Looks good. I think it's ok to leave out the first PR merge comment as we can thank people manually, not everything needs to be automated 😉
yvonnefroehlich
approved these changes
Oct 14, 2025
Member
|
Confirmed that it works - #4170 (comment) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Since the start of the project (efabb47), we have used the welcome bot to greet first-time contributors when they open an issue or submit a pull request. It has worked well, but the welcome bot has been unmaintained for five years.
This PR replaces it with the
actions/first-interactionworkflow, which is actively maintained and likely more lightweight — the welcome bot is a Probot app, whereasactions/first-interactionruns as a GitHub Action.One limitation of
actions/first-interactionis that it cannot comment when a pull request is merged. For now, I’ve combined thenewPRWelcomeCommentandfirstPRMergeCommentmessages intopr_message.We may implement theEdit: I don't think it's possible, since we can't know if a PR is someone's first PR.firstPRMergeCommentfunctionality usinggh pr commenttriggered by a PR merge event.I've tested the welcome workflow in my own fork. It works well, with a welcome comment at seisman#2 (the format of the message is fixed in 1bbfde2) and no comment at seisman#3.
TODO
Decide if we want to implement thefirstPRMergeCommentfunctionality in this PR