[PLAYER-90] fix camera false make mousevents failed #153
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
If mediamanager is not load (when camera is set to false by example) this.instance.mediaManager is undefiened and this.instance.mediaManager.isMuted throw an error so mouseevents are never send - move api logic to mute / unmute from mediaManager to apiManager, this way even if camera is disable video can be mute / unmute - change isMuted variable name by isForceMuted
caarmen
approved these changes
Sep 10, 2025
jparez
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
fix: camera set to false make mousevents failed
If mediamanager is not load (when camera is set to false by example) this.instance.mediaManager is undefiened and this.instance.mediaManager.isMuted throw an error so mouseevents are never send
Type of change