Skip to content

[Fixes #313] Bug in the NetworkRequesttask method which handles the timeout events #314

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 3 commits into
base: main
Choose a base branch
from
Open

[Fixes #313] Bug in the NetworkRequesttask method which handles the timeout events #314

Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
3e07def
pending reply bug
Gpetrak Oct 29, 2025
1042cb1
changing the typing of _pending_replies accordingly
Gpetrak Oct 30, 2025
95dd2a7
Merge branch 'main' into ISSUE_313
Gpetrak Oct 31, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 3 additions & 3 deletions src/qgis_geonode/tasks/network_task.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -16,7 +16,7 @@ class NetworkRequestTask(qgis.core.QgsTask):
requests_to_perform: typing.List[network.RequestToPerform]
response_contents: typing.List[typing.Optional[network.ParsedNetworkReply]]
_num_finished: int
_pending_replies: typing.Dict[int, typing.Tuple[int, QtNetwork.QNetworkReply]]
_pending_replies: typing.Dict[int, network.PendingReply]

_all_requests_finished = QtCore.pyqtSignal()
task_done = QtCore.pyqtSignal(bool)
Expand Down Expand Up @@ -176,11 +176,11 @@ def _handle_request_timed_out(
) -> None:
log(f"Request with id: {request_params.requestId()} has timed out")
try:
index, qt_reply = self._pending_replies[request_params.requestId()]
pending_reply = self._pending_replies[request_params.requestId()]
except KeyError:
pass # we are not managing this request, ignore
else:
self.response_contents[index] = None
self.response_contents[pending_reply.index] = None
self._num_finished += 1
if self._num_finished >= len(self.requests_to_perform):
self._all_requests_finished.emit()