Skip to content

Conversation

mcihad
Copy link
Contributor

@mcihad mcihad commented Aug 28, 2025

  • Created a new translation file for Turkish (tr) in djangojs.po.
  • Added translations for various messages related to file formats, error codes, and user interface prompts.
  • Included translations for HTTP error messages and their descriptions.
  • Ensured consistency in terminology and clarity in user-facing messages.

Checklist

Reviewing is a process done by project maintainers, mostly on a volunteer basis. We try to keep the overhead as small as possible and appreciate if you help us to do so by completing the following items. Feel free to ask in a comment if you have troubles with any of them.

For all pull requests:

  • Confirm you have read the contribution guidelines
  • You have sent a Contribution Licence Agreement (CLA) as necessary (not required for small changes, e.g., fixing typos in the documentation)
  • Make sure the first PR targets the master branch, eventual backports will be managed later. This can be ignored if the PR is fixing an issue that only happens in a specific branch, but not in newer ones.

The following are required only for core and extension modules (they are welcomed, but not required, for contrib modules):

  • There is a ticket in https://github.com/GeoNode/geonode/issues describing the issue/improvement/feature (a notable exemption is, changes not visible to end-users)
  • The issue connected to the PR must have Labels and Milestone assigned
  • PR for bug fixes and small new features are presented as a single commit
  • PR title must be in the form "[Fixes #<issue_number>] Title of the PR"
  • New unit tests have been added covering the changes, unless there is an explanation on why the tests are not necessary/implemented

Submitting the PR does not require you to check all items, but by the time it gets merged, they should be either satisfied or inapplicable.

- Created a new translation file for Turkish (tr) in djangojs.po.
- Added translations for various messages related to file formats, error codes, and user interface prompts.
- Included translations for HTTP error messages and their descriptions.
- Ensured consistency in terminology and clarity in user-facing messages.
Copy link

cla-bot bot commented Aug 28, 2025

Thank you for your pull request and welcome to our community. We require contributors to sign our Contributor License Agreement, and we don't seem to have the users @mcihad on file. In order for us to review and merge your code, please contact the project maintainers to get yourself added.

Copy link

@gemini-code-assist gemini-code-assist bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Summary of Changes

Hello @mcihad, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request introduces Turkish language support for GeoNode's JavaScript-driven messages. The primary goal is to enhance the user experience for Turkish-speaking users by providing localized text for various application components, including file formats, system error messages, and interactive user interface elements. This change involves adding a new translation file and populating it with the necessary Turkish strings, making the application more accessible and user-friendly in a new locale.

Highlights

  • New Turkish Translation File: A new translation file for the Turkish language (tr) has been introduced at geonode/locale/tr/LC_MESSAGES/djangojs.po. This file will house all JavaScript-related messages translated into Turkish.
  • File Format Translations: The pull request includes comprehensive translations for various file formats such as ESRI Shapefile, GeoTIFF, KML, GeoJSON, and more, ensuring that users interacting with these formats see their names in Turkish.
  • HTTP Error Message Localization: Critical HTTP error messages (e.g., 400 Bad Request, 401 Unauthorized, 404 Not Found, 500 Internal Server Error) and their detailed descriptions have been translated, improving user understanding of system errors.
  • User Interface and System Message Translations: Numerous user interface prompts and system messages, including those related to file uploads, GeoServer configuration, and general application interactions, have been translated to provide a fully localized experience.
Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point in your pull request via creating an issue comment (i.e. comment on the pull request page) using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands.

Feature Command Description
Code Review /gemini review Performs a code review for the current pull request in its current state.
Pull Request Summary /gemini summary Provides a summary of the current pull request in its current state.
Comment @gemini-code-assist Responds in comments when explicitly tagged, both in issue comments and review comments.
Help /gemini help Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here.

You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.

Footnotes

  1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution.

Copy link

@gemini-code-assist gemini-code-assist bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

Bu pull request, GeoNode JavaScript mesajları için Türkçe çeviriler eklemektedir. Çeviriler genel olarak iyi, ancak birkaç kritik sorun bulunmaktadır. Bazı programatik anahtarlar çevrilmiş, bu da muhtemelen işlevselliği bozacaktır. Ayrıca kullanıcıya yönelik bir mesaj için eksik bir çeviri bulunmaktadır. Ek olarak, birkaç çeviri 'fuzzy' olarak işaretlenmiştir ve aktif hale gelmeleri için bu işaretin kaldırılarak onaylanmaları gerekmektedir. Bu sorunlar için önerilerle birlikte özel yorumlar bıraktım.

Copy link

codecov bot commented Aug 28, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 73.70%. Comparing base (01350a9) to head (b25fa22).
⚠️ Report is 3 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff             @@
##           master   #13457      +/-   ##
==========================================
+ Coverage   72.60%   73.70%   +1.09%     
==========================================
  Files         919      919              
  Lines       54183    54183              
  Branches     6168     6168              
==========================================
+ Hits        39341    39936     +595     
+ Misses      13255    12644     -611     
- Partials     1587     1603      +16     
🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

Copy link

cla-bot bot commented Aug 28, 2025

Thank you for your pull request and welcome to our community. We require contributors to sign our Contributor License Agreement, and we don't seem to have the users @mcihad on file. In order for us to review and merge your code, please contact the project maintainers to get yourself added.

Copy link

cla-bot bot commented Aug 28, 2025

Thank you for your pull request and welcome to our community. We require contributors to sign our Contributor License Agreement, and we don't seem to have the users @mcihad on file. In order for us to review and merge your code, please contact the project maintainers to get yourself added.

@mcihad
Copy link
Contributor Author

mcihad commented Aug 28, 2025

I made the corrections and pushed the changes.

@mcihad mcihad changed the title Add Turkish translations for GeoNode JavaScript messages Add Turkish translations for GeoNode messages Aug 28, 2025
Copy link

cla-bot bot commented Aug 30, 2025

Thank you for your pull request and welcome to our community. We require contributors to sign our Contributor License Agreement, and we don't seem to have the users @mcihad on file. In order for us to review and merge your code, please contact the project maintainers to get yourself added.

@giohappy
Copy link
Contributor

@mcihad please include the .clabot file inside the PR with your username added to the end

Copy link

cla-bot bot commented Sep 15, 2025

Thank you for your pull request and welcome to our community. We require contributors to sign our Contributor License Agreement, and we don't seem to have the users @mcihad on file. In order for us to review and merge your code, please contact the project maintainers to get yourself added.

Copy link

cla-bot bot commented Sep 15, 2025

Thank you for your pull request and welcome to our community. We require contributors to sign our Contributor License Agreement, and we don't seem to have the users @mcihad on file. In order for us to review and merge your code, please contact the project maintainers to get yourself added.

@mcihad
Copy link
Contributor Author

mcihad commented Sep 18, 2025

@mcihad please include the .clabot file inside the PR with your username added to the end

I added it to the place you mentioned, but cla-bot still didn't pass.

@giohappy giohappy self-requested a review September 19, 2025 08:22
@giohappy
Copy link
Contributor

Got it, clabot fetched the .clabot file from master, and not the branch from this PR, so it cannot find your username.
NP I will force the approval.

@giohappy giohappy merged commit 1292fd6 into GeoNode:master Sep 19, 2025
11 of 12 checks passed
@giohappy giohappy added this to the 5.0.0 milestone Sep 19, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants