-
Notifications
You must be signed in to change notification settings - Fork 1.2k
Add Turkish translations for GeoNode messages #13457
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
- Created a new translation file for Turkish (tr) in djangojs.po. - Added translations for various messages related to file formats, error codes, and user interface prompts. - Included translations for HTTP error messages and their descriptions. - Ensured consistency in terminology and clarity in user-facing messages.
Thank you for your pull request and welcome to our community. We require contributors to sign our Contributor License Agreement, and we don't seem to have the users @mcihad on file. In order for us to review and merge your code, please contact the project maintainers to get yourself added. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Summary of Changes
Hello @mcihad, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!
This pull request introduces Turkish language support for GeoNode's JavaScript-driven messages. The primary goal is to enhance the user experience for Turkish-speaking users by providing localized text for various application components, including file formats, system error messages, and interactive user interface elements. This change involves adding a new translation file and populating it with the necessary Turkish strings, making the application more accessible and user-friendly in a new locale.
Highlights
- New Turkish Translation File: A new translation file for the Turkish language (
tr
) has been introduced atgeonode/locale/tr/LC_MESSAGES/djangojs.po
. This file will house all JavaScript-related messages translated into Turkish. - File Format Translations: The pull request includes comprehensive translations for various file formats such as ESRI Shapefile, GeoTIFF, KML, GeoJSON, and more, ensuring that users interacting with these formats see their names in Turkish.
- HTTP Error Message Localization: Critical HTTP error messages (e.g., 400 Bad Request, 401 Unauthorized, 404 Not Found, 500 Internal Server Error) and their detailed descriptions have been translated, improving user understanding of system errors.
- User Interface and System Message Translations: Numerous user interface prompts and system messages, including those related to file uploads, GeoServer configuration, and general application interactions, have been translated to provide a fully localized experience.
Using Gemini Code Assist
The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.
Invoking Gemini
You can request assistance from Gemini at any point in your pull request via creating an issue comment (i.e. comment on the pull request page) using either /gemini <command>
or @gemini-code-assist <command>
. Below is a summary of the supported commands.
Feature | Command | Description |
---|---|---|
Code Review | /gemini review |
Performs a code review for the current pull request in its current state. |
Pull Request Summary | /gemini summary |
Provides a summary of the current pull request in its current state. |
Comment | @gemini-code-assist | Responds in comments when explicitly tagged, both in issue comments and review comments. |
Help | /gemini help |
Displays a list of available commands. |
Customization
To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/
folder in the base of the repository. Detailed instructions can be found here.
Limitations & Feedback
Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here.
You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.
Footnotes
-
Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution. ↩
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Code Review
Bu pull request, GeoNode JavaScript mesajları için Türkçe çeviriler eklemektedir. Çeviriler genel olarak iyi, ancak birkaç kritik sorun bulunmaktadır. Bazı programatik anahtarlar çevrilmiş, bu da muhtemelen işlevselliği bozacaktır. Ayrıca kullanıcıya yönelik bir mesaj için eksik bir çeviri bulunmaktadır. Ek olarak, birkaç çeviri 'fuzzy' olarak işaretlenmiştir ve aktif hale gelmeleri için bu işaretin kaldırılarak onaylanmaları gerekmektedir. Bu sorunlar için önerilerle birlikte özel yorumlar bıraktım.
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #13457 +/- ##
==========================================
+ Coverage 72.60% 73.70% +1.09%
==========================================
Files 919 919
Lines 54183 54183
Branches 6168 6168
==========================================
+ Hits 39341 39936 +595
+ Misses 13255 12644 -611
- Partials 1587 1603 +16 🚀 New features to boost your workflow:
|
Thank you for your pull request and welcome to our community. We require contributors to sign our Contributor License Agreement, and we don't seem to have the users @mcihad on file. In order for us to review and merge your code, please contact the project maintainers to get yourself added. |
Thank you for your pull request and welcome to our community. We require contributors to sign our Contributor License Agreement, and we don't seem to have the users @mcihad on file. In order for us to review and merge your code, please contact the project maintainers to get yourself added. |
I made the corrections and pushed the changes. |
Thank you for your pull request and welcome to our community. We require contributors to sign our Contributor License Agreement, and we don't seem to have the users @mcihad on file. In order for us to review and merge your code, please contact the project maintainers to get yourself added. |
@mcihad please include the |
Thank you for your pull request and welcome to our community. We require contributors to sign our Contributor License Agreement, and we don't seem to have the users @mcihad on file. In order for us to review and merge your code, please contact the project maintainers to get yourself added. |
Thank you for your pull request and welcome to our community. We require contributors to sign our Contributor License Agreement, and we don't seem to have the users @mcihad on file. In order for us to review and merge your code, please contact the project maintainers to get yourself added. |
I added it to the place you mentioned, but cla-bot still didn't pass. |
Got it, clabot fetched the .clabot file from master, and not the branch from this PR, so it cannot find your username. |
Checklist
For all pull requests:
The following are required only for core and extension modules (they are welcomed, but not required, for contrib modules):
Submitting the PR does not require you to check all items, but by the time it gets merged, they should be either satisfied or inapplicable.