Skip to content

Conversation

@etj
Copy link
Contributor

@etj etj commented Oct 21, 2025

See #13649

Checklist

Reviewing is a process done by project maintainers, mostly on a volunteer basis. We try to keep the overhead as small as possible and appreciate if you help us to do so by completing the following items. Feel free to ask in a comment if you have troubles with any of them.

For all pull requests:

  • Confirm you have read the contribution guidelines
  • You have sent a Contribution Licence Agreement (CLA) as necessary (not required for small changes, e.g., fixing typos in the documentation)
  • Make sure the first PR targets the master branch, eventual backports will be managed later. This can be ignored if the PR is fixing an issue that only happens in a specific branch, but not in newer ones.

The following are required only for core and extension modules (they are welcomed, but not required, for contrib modules):

  • There is a ticket in https://github.com/GeoNode/geonode/issues describing the issue/improvement/feature (a notable exemption is, changes not visible to end-users)
  • The issue connected to the PR must have Labels and Milestone assigned
  • PR for bug fixes and small new features are presented as a single commit
  • PR title must be in the form "[Fixes #<issue_number>] Title of the PR"
  • New unit tests have been added covering the changes, unless there is an explanation on why the tests are not necessary/implemented

Submitting the PR does not require you to check all items, but by the time it gets merged, they should be either satisfied or inapplicable.

@cla-bot cla-bot bot added the cla-signed CLA Bot: community license agreement signed label Oct 21, 2025
@gemini-code-assist
Copy link
Contributor

Summary of Changes

Hello @etj, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request focuses on a significant refactoring effort to remove the django-modeltranslation library from the GeoNode project. The change streamlines the application by eliminating a third-party dependency and its associated multilingual features. This involves a comprehensive cleanup across the codebase, affecting model definitions, administrative interfaces, and form handling, and includes necessary database schema adjustments to remove deprecated translation fields.

Highlights

  • Dependency Removal: The django-modeltranslation library has been completely removed from the project, including its package from requirements.txt and its entry from INSTALLED_APPS.
  • Database Schema Updates: New database migrations have been added across multiple applications (base, documents, geoapps, groups, layers, maps, services) to remove all _en suffixed translation fields that were previously managed by django-modeltranslation.
  • Codebase Simplification: All translation.py files, which configured django-modeltranslation for various models, have been removed. Admin classes and forms have been updated to no longer inherit from TabbedTranslationAdmin, TranslationAdmin, or TranslationModelForm, reverting to standard Django admin.ModelAdmin and forms.ModelForm.
Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature Command Description
Code Review /gemini review Performs a code review for the current pull request in its current state.
Pull Request Summary /gemini summary Provides a summary of the current pull request in its current state.
Comment @gemini-code-assist Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help /gemini help Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here.

You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.

Footnotes

  1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution.

Copy link
Contributor

@gemini-code-assist gemini-code-assist bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request effectively removes the django-modeltranslation dependency from the project. The changes are comprehensive, including removal from requirements, Django settings, updating admin and form classes, and adding migrations to clean up the database schema. The removal appears to be executed correctly across all affected modules. The changes are systematic and well-executed.

@etj etj marked this pull request as draft October 21, 2025 15:50
@etj etj force-pushed the 13649_remove_modeltranslation branch from 32a27ba to cd91445 Compare October 21, 2025 16:18
@etj etj marked this pull request as ready for review October 22, 2025 08:11
@etj etj requested a review from giohappy October 22, 2025 08:18
@etj etj self-assigned this Oct 22, 2025
@etj etj force-pushed the 13649_remove_modeltranslation branch from cd91445 to fc5447a Compare October 22, 2025 16:29
@etj etj force-pushed the 13649_remove_modeltranslation branch from fc5447a to 22515c8 Compare October 22, 2025 16:42
@etj etj marked this pull request as draft October 22, 2025 17:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

cla-signed CLA Bot: community license agreement signed

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants