Some fixes for potion items

[BUGTeas]

• Add some code comments about:
  - Feature：Make custom effect information visible & Support for customizing item name via 'custom_name' tag in 'potion_contents' component (new feature since 1.21.2) #5176
  - Fix item_name component not work; Improve display of custom effects and shulker box tooltips for item names #5255
• Remove the incorrect prefix correctly in potion name
  Example: /give @s potion[potion_contents={potion:long_leaping,custom_effects:[{id:luck}]}]
  ->
• Fix tipped arrow always using name "Tipped Arrow" and not affected by potion components
  Example: /give @s minecraft:tipped_arrow[potion_contents={potion:leaping}]
  ->
• Fix the wrong Bedrock ID of tipped arrows in the tooltip of shulker box
  Example: /give @s minecraft:shulker_box[container=[{slot:0,item:{id:tipped_arrow,count:1,components:{potion_contents:{potion:leaping}}}}]]
  ->
• Optimize potion name when potion tooltip is hidden
• Able to display potion effects custom potion effects in normal arrow item all items just like Java Edition
  Example: /give @s apple[potion_contents={custom_effects:[{id:luck}]}]
  
• Add minecraft:potion_duration_scale component support (new feature since 1.21.5)

[eclipseisoffline]

Any reason for adding this instanceof check? Geyser tries to match Java behaviour, and Java shows the potion effect tooltip on all items with a potion_contents component, not just these specific items, so it's probably good to do the same.

Also, given the above, I'm not sure if Geyser should show the effect in the HUD name tooltip, since Java doesn't. However, that seems up to debate to me.

[BUGTeas]

Reason for show the effects in the HUD name tooltip

Bedrock always show effects in the HUD name tooltip, and show "No Effects" when it haven't any effects. If use lore to show these custom effects, Bedrock player will only saw effects or "No Effects" by vanilla potion ID.

/give @s potion[custom_name="Test",potion_contents={custom_effects:[{id:hero_of_the_village,duration:-1},{id:unluck,amplifier:1,duration:658980}]}]

/give @s potion[custom_name="Test 2",potion_contents={custom_effects:[{id:hero_of_the_village,duration:-1},{id:unluck,amplifier:1,duration:658980}],potion:leaping}]

But wrapping line in name can resolve this problem well:

At least, It reduce some misunderstandings of players, even if it looks a little wried.

[BUGTeas]

So, is the instanceof check before getting potion name in the getPotionName method used to use the custom_name of the potion_contents component only on tipped arrow & potion to match the Java behavior? I understand now.

For show custom effects on next line of the name, I think it have a better method to implement this. I'll take a look at it later.

[eclipseisoffline]

Bedrock always show effects in the HUD name tooltip, and show "No Effects" when it haven't any effects. If use lore to show these custom effects, Bedrock player will only saw effects or "No Effects" by vanilla potion ID.

Ah okay, thanks for clarifying! In that case, this makes sense to me. It might be good to document this in comments near the code as well, for future reference.

[onebeastchris]

Heya, what's the holdup here? 😄

[BUGTeas]

Heya, what's the holdup here? 😄

I deeply apologize, but I don't have time to continue this work for the time being. I will add some commit directly when I come back in future.

[BUGTeas]

Sorry I took too long. Now it can be review.