Support legacy versions of Fabric and NeoForge #5728
Draft
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
...trap/mod/fabric/src/main/java/org/geysermc/geyser/platform/fabric/GeyserFabricBootstrap.java
Outdated
Show resolved
Hide resolved
...trap/mod/fabric/src/main/java/org/geysermc/geyser/platform/fabric/GeyserFabricBootstrap.java
Outdated
Show resolved
Hide resolved
...trap/mod/fabric/src/main/java/org/geysermc/geyser/platform/fabric/GeyserFabricBootstrap.java
Outdated
Show resolved
Hide resolved
...strap/mod/fabric/src/main/java/org/geysermc/geyser/platform/fabric/GeyserFabricPlatform.java
Outdated
Show resolved
Hide resolved
Comment on lines
+89
to
+95
| if (!ModConstants.isModernVersion() && !this.platform.testViaPresent(this)) { | ||
| this.geyserLogger.error("-------------------------------------------------------------------------"); | ||
| this.geyserLogger.error("The current server version is not supported unless ViaVersion is present!"); | ||
| this.geyserLogger.error("Geyser will not start unless you add ViaVersion!"); | ||
| this.geyserLogger.error("-------------------------------------------------------------------------"); | ||
| return; | ||
| } |
There was a problem hiding this comment.
We could also throw a runtime exception :p
Or, alternatively, make the older adapters depend on via? dunno if that'd work on neo, I guess we'll see
There was a problem hiding this comment.
I think we should try depend in the adapters, but if that causes Neo issues, I think the current solution works good enough
|
Failing builds are expected, currently requires a local publish of this PR for it to compile, which GH actions doesn't have |
|
This should be good to merge once the modded adapters are merged in. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Supports 1.20.6-1.21.8 currently
This PR is currently on pause as modded adapters are figured out!