Skip to content

Conversation

@onebeastchris
Copy link
Member

@onebeastchris onebeastchris commented Jul 31, 2025

Main changes:

  • tablist display name, as well as gamemode are now stored per-player to correctly use for tablist display name formatting
  • prefix/suffix or color properties of scoreboard teams are also translated in the tablist names

TO-DOs:

  • tim's review as the scoreboard code god

@onebeastchris onebeastchris marked this pull request as draft August 4, 2025 23:11
@onebeastchris onebeastchris marked this pull request as ready for review August 12, 2025 00:03
@Tim203
Copy link
Member

Tim203 commented Aug 12, 2025

I have not looked at the actual behaviour of the code, but could you please add some tests for this new functionality? And reduce the diff by not touching the imports

@onebeastchris onebeastchris requested a review from Tim203 August 17, 2025 12:56
@onebeastchris onebeastchris added the PR: Needs Testing When a PR needs testing but is currently not under review label Aug 17, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

PR: Needs Testing When a PR needs testing but is currently not under review

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants