-
Notifications
You must be signed in to change notification settings - Fork 76
GitHub discussions integration #946
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
|
4127c18
to
40e3f62
Compare
commit: |
- store githubInstallationId in externalIds for filtering - fix webhook payload parsing with separate parseWebhookDiscussionAsGitBook - remove GitHubClient abstraction, use inline Octokit calls - add webhook secret to manifest
replace custom types with official Octokit types - Use components['schemas']['repository'] from @octokit/openapi-types for GitHubRepository - Use WebhookComponents['schemas']['discussion'] for GitHubWebhookDiscussion - Use WebhookComponents['schemas']['webhook-discussion-closed'] for GitHubWebhookPayload - Improves type safety and maintainability by leveraging official GitHub API types use generic syntax for GraphQL type assertion
a6480db
to
da58d0d
Compare
Summary
Creates a new GitHub Conversations integration that syncs GitHub Discussions to GitBook conversations.
Key features
Future work (separate PRs)
Handle user uninstalls to update GitBook installation (pending API changes), for proper cleanup.(not possible with installation token only, a user token is needed which has permissions on the installed target).setup_action=request
handling, e.g when user doesn't have permissions to install the GitHub app in a repo/org