Skip to content

Conversation

ZackeryRSmith
Copy link
Member

@ZackeryRSmith ZackeryRSmith commented Jun 17, 2025

Allows for a much cleaner separation of the logs. This PR introduces scaffolding for the options profile. Similar to how hint_color currently is. Works towards #450

BEFORE AFTER

impl. the usage of these into ModLoaderLog
@ZackeryRSmith
Copy link
Member Author

ZackeryRSmith commented Jun 17, 2025

As for using the options profile scaffolds. If ModLoaderStore is nil, which in most cases it isn't, we could just use fallback colors.

Alternatively, ModLoaderStore logs get to be bland and colorless. I'm reaching for this option, as these logs are very minimal (literately just a single line) and at the top.

Scratch all that, just now seeing _configure_logger

@ZackeryRSmith ZackeryRSmith added enhancement New feature or request 4.x labels Jun 17, 2025
@ZackeryRSmith ZackeryRSmith enabled auto-merge June 17, 2025 05:24
@ZackeryRSmith ZackeryRSmith requested review from KANAjetzt and Qubus0 and removed request for Qubus0 June 17, 2025 21:52
@ZackeryRSmith
Copy link
Member Author

ZackeryRSmith commented Jun 18, 2025

OLD NEW

being a debug log it felt weird to have color
@KANAjetzt KANAjetzt added this to the 4.x - 7.x milestone Jun 21, 2025
@KANAjetzt
Copy link
Member

image

Two things:

  • Do we want DEBUG to be bold as well?
  • In the editor, we can remove the ERROR prefix.

@ZackeryRSmith
Copy link
Member Author

Do we want DEBUG to be bold as well?

I'm going to argue, no. Debug logs are, well debug. Color and boldness draws attention. It's common practice to reserve color for status', warnings, or errors. Giving debug logs a color elevates them visually to the same importance, which for me breaks the mental model. Where you can just filter the logs for your mods debug messages, I find personally that keeping debug unbold is the way to go. For reference this is what bold debugs look like

Original colored log screenshot in this PR

In the editor, we can remove the ERROR prefix.

Never noticed that, but you're right, let me make that change

this removes the duplicate "ERROR: ERROR" at the start of error logs
@KANAjetzt
Copy link
Member

Fair point. I think there is still enough separation between the log types with the color alone, and the bold prefix ties all the Mod Loader logs together.
image

Adding a bold toggle in the options for each log type might be a bit excessive, but maybe just one for debug?

@ZackeryRSmith
Copy link
Member Author

Agree with you there. Let's make bold the default option for debug logs with an optional toggle. I'll make the changes once I get home

Copy link
Member

@KANAjetzt KANAjetzt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Only some small nitpicks, looks very nice, ty👍

@ZackeryRSmith ZackeryRSmith added this pull request to the merge queue Jun 28, 2025
Merged via the queue into GodotModding:4.x-dev with commit e96efd6 Jun 28, 2025
1 check passed
@ZackeryRSmith
Copy link
Member Author

I'll write a follow up PR which addresses the suggested changes

ZackeryRSmith added a commit to ZackeryRSmith/godot-mod-loader that referenced this pull request Jun 28, 2025
KANAjetzt pushed a commit to ZackeryRSmith/godot-mod-loader that referenced this pull request Jul 8, 2025
KANAjetzt added a commit that referenced this pull request Jul 8, 2025
* style: clean nit picks from #562

* bug: fix editor feature check

doesn't error when ModLoaderStore isn't initialized

* bug: remove usage of deleted function `is_version_below`

* chore: simplify editor check in `_print_rich`

* chore: commit KANAjetzt's suggestion

Co-authored-by: KANAjetzt <[email protected]>

---------

Co-authored-by: KANAjetzt <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

4.x enhancement New feature or request

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants