Skip to content

Conversation

ZackeryRSmith
Copy link
Member

@ZackeryRSmith ZackeryRSmith commented Jun 28, 2025

Loses engine hex version checking, but seeing as we're below version 4.2 anyway the check isn't required anymore

loses engine version checking, I'm sure this can easily be brought back though
Copy link
Member

@KANAjetzt KANAjetzt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm assuming you tested hook gen and mod loading on 4.0? 😁
The code looks good, only one small comment about the version check.
You can add an issue for that, just to keep track of it. 👍

return autoload_index


static func is_version_below(version_hex: int) -> bool:
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks like is_version_below is still called in file.gd

@ZackeryRSmith
Copy link
Member Author

I'm assuming you tested hook gen and mod loading on 4.0? 😁

You might be disappointed, I didn't test hook gen 😢
Mod loading, resource overwriting, and so on does work though. Let me test hook gen right now!

@ZackeryRSmith
Copy link
Member Author

Hook gen is broken, but due to my lack of knowledge on the subject I don't even have an idea of where to look...

I'll push my changes currently, where still, everything works other than hook gen.

@KANAjetzt KANAjetzt merged commit ed77a75 into GodotModding:4.0 Jul 6, 2025
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

4.x 4.0 enhancement New feature or request

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants