chore: backport 4.x to 4.0 #567
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
loses engine version checking, I'm sure this can easily be brought back though
KANAjetzt
approved these changes
Jun 29, 2025
| return autoload_index | ||
|
|
||
|
|
||
| static func is_version_below(version_hex: int) -> bool: |
There was a problem hiding this comment.
looks like is_version_below is still called in file.gd
You might be disappointed, I didn't test hook gen 😢 |
|
Hook gen is broken, but due to my lack of knowledge on the subject I don't even have an idea of where to look... I'll push my changes currently, where still, everything works other than hook gen. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Loses engine hex version checking, but seeing as we're below version 4.2 anyway the check isn't required anymore