Skip to content

Add existing focusable elements to correctly manage tab key navigation #228

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open

Add existing focusable elements to correctly manage tab key navigation #228

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
17596e2
Add existing focusable elements to correctly manage tab key navigation
jelmerdemaat Nov 26, 2021
fd06c67
Add any element with [contenteditable] attribute to focusable elements
jelmerdemaat Nov 26, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion index.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -126,7 +126,7 @@ function isFormMethodDialog(el) {
function findFocusableElementWithin(hostElement) {
// Note that this is 'any focusable area'. This list is probably not exhaustive, but the
// alternative involves stepping through and trying to focus everything.
var opts = ['button', 'input', 'keygen', 'select', 'textarea'];
var opts = ['button', 'input', 'keygen', 'select', 'textarea', 'a[href]', 'area[href]', 'iframe', 'object', 'embed', '[contenteditable]'];
var query = opts.map(function(el) {
return el + ':not([disabled])';
});
Expand Down
2 changes: 1 addition & 1 deletion package-lock.json
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.