Skip to content

fix: respect project id for incoming identifier #1340

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open

fix: respect project id for incoming identifier #1340

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
044adad
fix: respect project id for incoming identifier
thomaschow Feb 23, 2025
b8a7b95
check null
thomaschow Feb 24, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
13 changes: 10 additions & 3 deletions ...spark-3.5-bigquery-lib/src/main/java/com/google/cloud/spark/bigquery/BigQueryCatalog.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -121,16 +121,23 @@ public Identifier[] listTables(String[] namespace) throws NoSuchNamespaceExcepti
@Override
public Table loadTable(Identifier identifier) throws NoSuchTableException {
logger.debug("loading table [{}])", format(identifier));
TableId tableId = toTableId(identifier);
Map config = tableId.getProject() != null ?
ImmutableMap.of(
"project", tableId.getProject(),
"dataset", tableId.getDataset(),
"table", tableId.getTable()) :
ImmutableMap.of(
"dataset", tableId.getDataset(),
"table", tableId.getTable());
try {
return identifierToTableCache.get(
identifier.toString(),
() ->
// TODO: reuse injector
Spark3Util.createBigQueryTableInstance(
Spark35BigQueryTable::new,
null,
ImmutableMap.of(
"dataset", identifier.namespace()[0], "table", identifier.name())));
null, config));
} catch (ExecutionException e) {
throw new BigQueryConnectorException("Problem loaing table " + identifier, e);
}
Expand Down