return a v1write even for truncate #1353
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
/gcbrun |
|
Thanks for the contribution! It failed on |
|
/gcbrun |
|
Please run |
|
/gcbrun |
|
/gcbrun |
|
Hi @isha97, is there anything outstanding I should do for this PR? Please help me understand the failing checks, thanks! |
|
Notice that SupportsOverwrite is not fully implemented, specifically the |
|
Hi @davidrabinowitz thank you for the response!
Wasn't this the case prior? Since the implementation of that comes from |
hemanthbonthu
pushed a commit
to hemanthbonthu/spark-bigquery-connector
that referenced
this pull request
Jul 22, 2025
…1353) * Add new flag 'fs.gs.cloud.logging.enable' to export logs to cloud logging. * Add LoggingInterceptor to intercept log records sent to flogger and write those log records to Cloud logging. Also added unit test * Add LoggingInterceptor to intercept log records sent to flogger and write those log records to Cloud logging. Also added unit test * Configure logging configuration and add it to root logger handler. * Configure logging configuration and add it to root logger handler. * Merge remote-tracking branch 'origin/exp' into exp * Use credentials to create logging client. Structure log entry to include class and method name * Use credentials to create logging client. Structure log entry to include class and method name * Fix unit tests. * Add java doc, sort configuration and resolve other review comments. * Add java doc, sort configuration and resolve other review comments.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Spark35BigQueryWriteBuildersupports V1Write butBigQueryWriteBuilderis not an instance ofV1Write. We need to return aV1Writeinstance for truncate.