Adding Code Review by Gemini AI GitHub action

[davidrabinowitz]

No description provided.

[gemini-code-assist]

Summary of Changes

Hello @davidrabinowitz, I'm Gemini Code Assist¹! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request refactors how the Google Cloud project ID is determined within the acceptance and integration tests for the Spark BigQuery connector. It introduces a more robust and flexible mechanism for resolving the project ID, allowing tests to proceed even if the GOOGLE_CLOUD_PROJECT environment variable is not explicitly set, by falling back to the default project ID configured for the environment. Please note: The provided PR title 'Adding Code Review by Gemini AI GitHub action' does not align with the actual code changes in this pull request, which are focused on Java test constants.

Highlights

• Flexible Project ID Resolution: I've modified AcceptanceTestConstants.java and TestConstants.java to use Optional.ofNullable(System.getenv("GOOGLE_CLOUD_PROJECT")).orElse(ServiceOptions.getDefaultProjectId()) for determining the PROJECT_ID.
• Reduced Environment Variable Dependency: The GOOGLE_CLOUD_PROJECT environment variable is no longer a strict requirement for running these tests. The system will now attempt to use the default Google Cloud project if the variable is absent, improving test flexibility.
• Dependency Updates: I've added necessary imports for com.google.cloud.ServiceOptions and java.util.Optional in the affected test constant files to support the new project ID resolution logic.

Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point in your pull request via creating an issue comment (i.e. comment on the pull request page) using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands.

Feature	Command	Description
Code Review	/gemini review	Performs a code review for the current pull request in its current state.
Pull Request Summary	/gemini summary	Provides a summary of the current pull request in its current state.
Comment	@gemini-code-assist	Responds in comments when explicitly tagged, both in issue comments and review comments.
Help	/gemini help	Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist is currently in preview and may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments to provide feedback.

You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.

Footnotes

1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution. ↩

[gemini-code-assist]

Code Review

The pull request introduces a fallback to ServiceOptions.getDefaultProjectId() if the GOOGLE_CLOUD_PROJECT environment variable is not set. To ensure tests fail fast with a clear message if PROJECT_ID is unresolvable, consider throwing a NullPointerException.

[gemini-code-assist]

Consider throwing a NullPointerException with a descriptive message if the project ID cannot be resolved from the environment variable or ADC.

Suggested change

	Optional.ofNullable(System.getenv("GOOGLE_CLOUD_PROJECT"))
	.orElse(ServiceOptions.getDefaultProjectId());
	PROJECT_ID = Optional.ofNullable(System.getenv("GOOGLE_CLOUD_PROJECT"))
	.orElseGet(() -> {
	String projectId = ServiceOptions.getDefaultProjectId();
	if (projectId == null) {
	throw new NullPointerException("PROJECT_ID could not be determined. Please set the 'GOOGLE_CLOUD_PROJECT' environment variable or ensure Application Default Credentials are configured.");
	}
	return projectId;
	});