-
Notifications
You must be signed in to change notification settings - Fork 14
chore: encapsulate column fields logic #84
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
chore: encapsulate column fields logic #84
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Summary of Changes
Hello @andre-sampaio, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!
This pull request significantly refactors the Bigtable Spark connector by encapsulating all Bigtable row conversion and mutation logic within the BigtableTableCatalog
. This change streamlines the ReadRowConversions
and WriteRowConversions
APIs and resolves a critical issue affecting push-down joins when dealing with compound row keys.
Highlights
- Encapsulation of Column Logic: I've refactored the Bigtable row conversion logic (both reading and writing) by moving it into the
BigtableTableCatalog
class. This centralizes the handling of column fields and mutations, improving modularity. - API Simplification: The
ReadRowConversions.buildRow
method now accepts aSeq[String]
(column names) directly, simplifying its interface and removing the need for an intermediateSeq[Field]
mapping. - Bug Fix: Compound Row Keys in Joins: I've addressed a bug where push-down joins would not work correctly with compound row keys. This was fixed by ensuring the
catalog.row.getBtRowKeyBytes
method is used for accurate row key conversion during join operations.
Using Gemini Code Assist
The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.
Invoking Gemini
You can request assistance from Gemini at any point in your pull request via creating an issue comment (i.e. comment on the pull request page) using either /gemini <command>
or @gemini-code-assist <command>
. Below is a summary of the supported commands.
Feature | Command | Description |
---|---|---|
Code Review | /gemini review |
Performs a code review for the current pull request in its current state. |
Pull Request Summary | /gemini summary |
Provides a summary of the current pull request in its current state. |
Comment | @gemini-code-assist | Responds in comments when explicitly tagged, both in issue comments and review comments. |
Help | /gemini help |
Displays a list of available commands. |
Customization
To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/
folder in the base of the repository. Detailed instructions can be found here.
Limitations & Feedback
Gemini Code Assist is currently in preview and may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments to provide feedback.
You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.
Footnotes
-
Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution. ↩
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Code Review
The pull request successfully encapsulates column fields logic into BigtableTableCatalog
, significantly improving modularity and maintainability for both read and write operations. It also addresses a bug related to push-down joins with compound row keys by correctly handling row key byte conversion. A critical issue was identified where a necessary import is missing in BigtableTableCatalog.scala
, which will cause a compilation failure.
Also fix a bug where push down joins would not work with compound row keys.
ReadRowConversions was kept in place to simplify this PR but will be removed in a subsequent cl.