Skip to content

Add Slurm default_auth_key #4562

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 1 commit into from
Closed

Add Slurm default_auth_key #4562

wants to merge 1 commit into from

Conversation

@ACW101
Copy link
Collaborator

@ACW101 ACW101 commented Aug 22, 2025

Submission Checklist

NOTE: Community submissions can take up to 2 weeks to be reviewed.

Please take the following actions before submitting this pull request.

  • Fork your PR branch from the Toolkit "develop" branch (not main)
  • Test all changes with pre-commit in a local branch #
  • Confirm that "make tests" passes all tests
  • Add or modify unit tests to cover code changes
  • Ensure that unit test coverage remains above 80%
  • Update all applicable documentation
  • Follow Cluster Toolkit Contribution guidelines #

@ACW101 ACW101 requested review from a team and samskillman as code owners August 22, 2025 07:16
@ACW101 ACW101 force-pushed the default_slurm_key branch from 7fe353e to 4ed0235 Compare August 22, 2025 18:13
@samskillman samskillman added the release-chore To not include into release notes label Aug 22, 2025
@mr0re1 mr0re1 added the do-not-merge Block merging of this PR label Aug 26, 2025
@ACW101 ACW101 mentioned this pull request Sep 4, 2025
Merged
samskillman
samskillman requested changes Sep 9, 2025
View reviewed changes
Copy link
Collaborator

@samskillman samskillman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Needs re-evaluation on how to distribute this key.

@ACW101
Copy link
Collaborator Author

ACW101 commented Sep 9, 2025

Close in favor of #4607

@ACW101 ACW101 closed this Sep 9, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@samskillman samskillman samskillman requested changes

@sharabiani sharabiani sharabiani approved these changes

Assignees

No one assigned

Labels

do-not-merge Block merging of this PR release-chore To not include into release notes

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@ACW101 @samskillman @sharabiani @mr0re1