Skip to content

Disable topology plugin in slurm for large sized clusters #4579

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
wants to merge 1 commit into
base: develop
Choose a base branch
from
Draft

Disable topology plugin in slurm for large sized clusters #4579

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
15 changes: 15 additions & 0 deletions community/modules/scheduler/schedmd-slurm-gcp-v6-controller/main.tf
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -28,6 +28,21 @@ locals {
universe_domain = { "universe_domain" = var.universe_domain }
}

locals {
# Large size cluster with dynamic nodes can cause frequent controller reconfigures if topology plugin is enabled.
total_nodes = sum([for ns in var.nodeset : (ns.node_count_dynamic_max)])

cloud_parameters_override = {
topology_plugin = (var.cloud_parameters.topology_plugin == null && local.total_nodes > 50) ? "" : var.cloud_parameters.topology_plugin
suspend_timeout = (var.cloud_parameters.suspend_timeout == null && local.total_nodes > 50) ? 500 : var.cloud_parameters.suspend_timeout
}

cloud_parameters = merge(
var.cloud_parameters,
local.cloud_parameters_override
)
}

# See
# * slurm_files.tf
# * controller.tf
Expand Down
2 changes: 1 addition & 1 deletion community/modules/scheduler/schedmd-slurm-gcp-v6-controller/slurm_files.tf
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -141,7 +141,7 @@ module "slurm_files" {
slurm_conf_tpl = var.slurm_conf_tpl
slurm_conf_template = var.slurm_conf_template
cgroup_conf_tpl = var.cgroup_conf_tpl
cloud_parameters = var.cloud_parameters
cloud_parameters = local.cloud_parameters
cloudsql_secret = try(
one(google_secret_manager_secret_version.cloudsql_version[*].id),
null)
Expand Down
Loading