-
Notifications
You must be signed in to change notification settings - Fork 1.8k
feat(genai): Add samples for Controlled, Safety and Video generation. #5377
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
feat(genai): Add samples for Controlled, Safety and Video generation. #5377
Conversation
Here is the summary of changes. You are about to add 2 region tags.
This comment is generated by snippet-bot.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Summary of Changes
Hello @cfloress, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!
This pull request introduces new Go samples for the Google Generative AI SDK, expanding its capabilities to include controlled content generation using schemas, enhanced safety settings for text output, and the ability to generate videos from both text and image inputs. These additions provide developers with practical examples for leveraging advanced GenAI features.
Highlights
- Controlled Generation Sample: Added a new Go sample demonstrating how to enforce a specific JSON schema for generated text, including support for nested objects and enumerated types.
- Safety Settings Sample: Introduced a new Go sample showcasing the application of safety settings to text generation requests, allowing users to configure thresholds for various harm categories.
- Video Generation Samples: Provided two new Go samples for video generation: one that generates video based on a text prompt and another that generates video from an input image, both with configurable aspect ratios and GCS output.
Using Gemini Code Assist
The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.
Invoking Gemini
You can request assistance from Gemini at any point in your pull request via creating an issue comment (i.e. comment on the pull request page) using either /gemini <command>
or @gemini-code-assist <command>
. Below is a summary of the supported commands.
Feature | Command | Description |
---|---|---|
Code Review | /gemini review |
Performs a code review for the current pull request in its current state. |
Pull Request Summary | /gemini summary |
Provides a summary of the current pull request in its current state. |
Comment | @gemini-code-assist | Responds in comments when explicitly tagged, both in issue comments and review comments. |
Help | /gemini help |
Displays a list of available commands. |
Customization
To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/
folder in the base of the repository. Detailed instructions can be found here.
Limitations & Feedback
Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here.
You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.
Footnotes
-
Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution. ↩
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Code Review
This pull request adds several new Go samples for the GenAI SDK, covering controlled generation, safety settings, and video generation. The code is generally well-structured and the examples are clear.
I have a few suggestions to improve the code quality and fix a bug in the tests:
- In the safety sample, a prompt string contains unnecessary whitespace which should be removed for better readability.
- The two video generation samples share a significant amount of duplicate code. I recommend refactoring this into a common helper function to improve maintainability.
- The test for video generation uses a hardcoded placeholder for a GCS bucket name, which is a critical issue that will cause the tests to fail. This must be corrected.
Detailed feedback is provided in the comments on the respective files.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
CICD says multiple samples failed CICD tests with |
Currently working on that....Thank you! :) |
…into genai-ctrl-safety-videogen
…ng-samples into genai-ctrl-safety-videogen
…ng-samples into genai-ctrl-safety-videogen
…into genai-ctrl-safety-videogen
Description
Fixes #
Note: Before submitting a pull request, please open an issue for discussion if you are not associated with Google.
Checklist
go test -v ./..
(see Testing)gofmt
(see Formatting)go vet
(see Formatting)