Skip to content

Conversation

cfloress
Copy link
Contributor

@cfloress cfloress commented Aug 28, 2025

Description

Fixes #

Note: Before submitting a pull request, please open an issue for discussion if you are not associated with Google.

Checklist

  • I have followed Contributing Guidelines from CONTRIBUTING.MD
  • Tests pass: go test -v ./.. (see Testing)
  • Code formatted: gofmt (see Formatting)
  • Vetting pass: go vet (see Formatting)
  • These samples need a new API enabled in testing projects to pass (let us know which ones)
  • These samples need a new/updated env vars in testing projects set to pass (let us know which ones)
  • This sample adds a new sample directory, and I updated the CODEOWNERS file with the codeowners for this sample
  • This sample adds a new Product API, and I updated the Blunderbuss issue/PR auto-assigner with the codeowners for this sample
  • Please merge this PR for me once it is approved

@cfloress cfloress requested review from a team as code owners August 28, 2025 21:12
@product-auto-label product-auto-label bot added the samples Issues that are directly related to samples. label Aug 28, 2025
Copy link

snippet-bot bot commented Aug 28, 2025

Here is the summary of changes.

You are about to add 2 region tags.

This comment is generated by snippet-bot.
If you find problems with this result, please file an issue at:
https://github.com/googleapis/repo-automation-bots/issues.
To update this comment, add snippet-bot:force-run label or use the checkbox below:

  • Refresh this comment

Copy link
Contributor

@gemini-code-assist gemini-code-assist bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Summary of Changes

Hello @cfloress, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request introduces new Go samples for the Google Generative AI SDK, expanding its capabilities to include controlled content generation using schemas, enhanced safety settings for text output, and the ability to generate videos from both text and image inputs. These additions provide developers with practical examples for leveraging advanced GenAI features.

Highlights

  • Controlled Generation Sample: Added a new Go sample demonstrating how to enforce a specific JSON schema for generated text, including support for nested objects and enumerated types.
  • Safety Settings Sample: Introduced a new Go sample showcasing the application of safety settings to text generation requests, allowing users to configure thresholds for various harm categories.
  • Video Generation Samples: Provided two new Go samples for video generation: one that generates video based on a text prompt and another that generates video from an input image, both with configurable aspect ratios and GCS output.
Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point in your pull request via creating an issue comment (i.e. comment on the pull request page) using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands.

Feature Command Description
Code Review /gemini review Performs a code review for the current pull request in its current state.
Pull Request Summary /gemini summary Provides a summary of the current pull request in its current state.
Comment @gemini-code-assist Responds in comments when explicitly tagged, both in issue comments and review comments.
Help /gemini help Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here.

You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.

Footnotes

  1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution.

Copy link
Contributor

@gemini-code-assist gemini-code-assist bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request adds several new Go samples for the GenAI SDK, covering controlled generation, safety settings, and video generation. The code is generally well-structured and the examples are clear.

I have a few suggestions to improve the code quality and fix a bug in the tests:

  • In the safety sample, a prompt string contains unnecessary whitespace which should be removed for better readability.
  • The two video generation samples share a significant amount of duplicate code. I recommend refactoring this into a common helper function to improve maintainability.
  • The test for video generation uses a hardcoded placeholder for a GCS bucket name, which is a critical issue that will cause the tests to fail. This must be corrected.

Detailed feedback is provided in the comments on the respective files.

Copy link
Member

@msampathkumar msampathkumar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@msampathkumar msampathkumar added the kokoro:run Add this label to force Kokoro to re-run the tests. label Sep 2, 2025
@kokoro-team kokoro-team removed the kokoro:run Add this label to force Kokoro to re-run the tests. label Sep 2, 2025
@msampathkumar
Copy link
Member

CICD says multiple samples failed CICD tests with failed: video generation failed or returned no results

@cfloress

@cfloress
Copy link
Contributor Author

cfloress commented Sep 3, 2025

CICD says multiple samples failed CICD tests with failed: video generation failed or returned no results

@cfloress

Currently working on that....Thank you! :)

@msampathkumar msampathkumar added the kokoro:run Add this label to force Kokoro to re-run the tests. label Sep 10, 2025
@kokoro-team kokoro-team removed the kokoro:run Add this label to force Kokoro to re-run the tests. label Sep 10, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
samples Issues that are directly related to samples.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants