Skip to content

chore(deps): update dependency xmltodict to v1 #13566

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

chore(deps): update dependency xmltodict to v1 #13566

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion functions/http/requirements.txt
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
functions-framework==3.9.2
google-cloud-storage==2.9.0; python_version < '3.7'
google-cloud-storage==2.9.0; python_version > '3.6'
xmltodict==0.13.0
xmltodict==1.0.0
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

critical

The update to xmltodict version 1.0.0 requires Python 3.9+, as stated in the release notes. However, other dependencies in this file, such as functions-framework==3.9.2, indicate support for Python 3.8. This version mismatch will cause dependency installation to fail on Python 3.8 environments. To maintain compatibility, I recommend pinning xmltodict to the latest version that supports Python 3.8, which is 0.15.1.

xmltodict==0.15.1