Fix CLI installation and add Windows compatibility for scripts #6166
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
artf
approved these changes
Sep 24, 2024
There was a problem hiding this comment.
Thanks @mohamedsalem401 🙇♂️
I removed for now postinstall as I think we want to avoid the consumers running build when they install grapesjs as a dependency.
We should probably highlight the CLI build step in the Development steps
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
To use the GrapesJS framework via the CLI, we must first build the CLI itself. Therefore, we should add a build step for the CLI after the installation process.
I also added cross-env before some script so that they will work on Windows machines.