Improve FindBFD.cmake #144
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bfd.h now required PACKAGE and PACKAGE_VERSION to be defined, set these in CMakeList.txt
…ixed cmake module to respect this change.
Added (boost::uint64_t) to State:Write for correct size of int
Conflicts: libgrive/src/drive/State.cc
Conflicts: CMakeLists.txt libgrive/src/drive/State.cc libgrive/src/drive/State.hh
Conflicts: cmake/Modules/FindJSONC.cmake libgrive/CMakeLists.txt
Conflicts: libgrive/src/drive/State.cc
Conflicts: libgrive/CMakeLists.txt libgrive/src/drive/State.cc
Conflicts: libgrive/src/drive/State.cc
Conflicts: cmake/Modules/FindJSONC.cmake
Conflicts: libgrive/src/drive/State.cc
Check if bfd.h can be included (fixes #72)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Test if bfd.h can be included and only then set BFD_FOUND to true.