-
-
Notifications
You must be signed in to change notification settings - Fork 309
Rework Fortran configure to allow cross compile overrides #5720
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: develop
Are you sure you want to change the base?
Conversation
The mingw cross-compile gets past the configure stage and then chokes on: because the values from the defaults are not correctly formatted. Once the syntax is correct then we can update the toolchain with the correct values. |
The requirement is to specify the correct values in a toolchain file. gfortran defaults are just in case. |
Where is CROSSCOMPILING_PATH defined? |
set (CMAKE_FIND_ROOT_PATH_MODE_INCLUDE ONLY) | ||
set (CMAKE_FIND_ROOT_PATH_MODE_PACKAGE ONLY) | ||
set (CMAKE_CROSSCOMPILING_EMULATOR wine64) | ||
set (CROSSCOMPILING_PATH "WINEPATH=/usr/${TOOLCHAIN_PREFIX}/sys-root/mingw/bin/") |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
toolchain defines CROSSCOMPILING_PATH or it must be on the command line.
Another possibility using defaults and toolchain file could overwrite.
See #5709 and #5718
The expectation is that cross-compiling will use a toolchain file to provide the correct values.
The defaults are only one way to provide defaults for a specific compiler.
NOTE: The supplied toolchain and Fortran pre-gen files are specific for mingw/gfortran - each platform/compiler will need to supply its own set of files/values.
Important
Rework
HDF5UseFortran.cmake
to support cross-compilation by providing default KINDs and sizes.HDF5UseFortran.cmake
to handle cross-compilation by providing default KINDs and sizes whenCMAKE_CROSSCOMPILING
is true.CMAKE_CROSSCOMPILING
to determine if default values should be used.{1,2,4,8,16}
and REAL KINDs{4,8,10,16}
.This description was created by
for 0b8f640. You can customize this summary. It will automatically update as commits are pushed.