Disable szip/deflate tests when test files can't be generated #5909
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mattjala
added
the
Component - Testing
mattjala
requested review from
byrnHDF,
derobins,
fortnern and
lrknox
as code owners
mattjala
requested review from
bmribler,
brtnfld,
glennsong09,
jhendersonHDF,
qkoziol and
vchoi-hdfgroup
as code owners
byrnHDF
reviewed
Oct 11, 2025
| # SZIP | ||
| ADD_H5_TEST (tszip RESULT_CODE 0 APPLY_FILTERS 2 --enable-error-stack -H -p -d szip TARGET_FILE tfilters.h5) | ||
| # For VOL connectors, test files are generated during testing, which requires the filter itself to be available. | ||
| if (HDF5_ENABLE_SZIP_SUPPORT) |
There was a problem hiding this comment.
Are we sure this will be correct if HDF5_ENABLE_SZIP_SUPPORT is true yet fails to actually succeed in implementing it?
There was a problem hiding this comment.
In CMakeFilters.cmake, it looks like HDF5_ENABLE_SZIP_SUPPORT is turned off if the build tries to enable it and fails (line 256). So the case you describe should be unable to occur.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This should fix the CI test failures with the external passthrough VOL.
Important
Disable
tszipandtdeflatetests inCMakeTests.cmakewhen SZIP or deflate filters are unavailable to fix CI test failures.tszipandtdeflatetests inCMakeTests.cmakeif SZIP or deflate filters are unavailable, respectively.NATIVE_ONLYflag totszip,tdeflate, andtallfilterstests when filters are not available.HDF5_ENABLE_SZIP_SUPPORTfor SZIP filter availability.H5_HAVE_FILTER_DEFLATEfor deflate filter availability.This description was created by
for ab914d2. You can customize this summary. It will automatically update as commits are pushed.