-
Notifications
You must be signed in to change notification settings - Fork 15
Feat/mlflow models from code migration audio translation with nemo #273
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
gabisponciano
wants to merge
15
commits into
main
Choose a base branch
from
feat/mlflow-models-from-code-migration-audio-translation-with-nemo
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Feat/mlflow models from code migration audio translation with nemo #273
gabisponciano
wants to merge
15
commits into
main
from
feat/mlflow-models-from-code-migration-audio-translation-with-nemo
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…at/mlflow-models-from-code-migration-audio-translation-with-nemo
f62e879 to
5eac055
Compare
…n-with-nemo' of https://github.com/HPInc/AI-Blueprints into feat/mlflow-models-from-code-migration-audio-translation-with-nemo
ata-turhan
approved these changes
Oct 14, 2025
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks great 🚀
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
dependencies
Pull requests that update a dependency file
enhancement
Improvements to existing features
python
Pull requests that update python code
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
MLflow 3.1.0 Models-from-Code Migration for Audio Translation with NeMo Blueprint
Overview
Successfully migrated the Audio Translation with NeMo blueprint from MLflow's legacy serialization-based model logging (
python_model) to the modern models-from-code approach (loader_module+data_path). This comprehensive architectural refactoring resolves critical MLflow 3.1.0 compatibility issues and adopts the universal structure standardization that synchronizes shared loader/logger implementation with the canonical Vanilla-RAG blueprint (PR #208).🎯 LATEST UPDATE: Applied universal structure standardization following PR #208 pattern with generic class names (
Model,Logger) and synchronized shared loader/logger implementation, eliminating blueprint-specific prefixes for better maintainability across all AI blueprints.Technical Changes
Universal Structure Standardization ✨
File Structure Migration
Generic Class Names & Synchronized Implementation
Model(formerlyAudioTranslationModel): Framework-agnostic NeMo audio translation business logic layerLogger(exact copy from PR feat: MLflow 3.1.0 Models-from-Code Migration for Vanilla RAG Blueprint #208): Universal MLflow registration and artifact management layerloader.py(exact copy from PR feat: MLflow 3.1.0 Models-from-Code Migration for Vanilla RAG Blueprint #208): Universal MLflow models-from-code entry pointfrom src.mlflow import Model, Loggerloader_module="src.mlflow.loader"New Architecture Components
loader.py(Synchronized with PR #208)_load_pyfunc()functionModelinstance for predictionmodel.py(Refactored for Universal Pattern + NeMo Specialization)Model(config, docs_path, model_path, secrets)predict(model_input, params)signature for backward compatibilityRefactored Service Architecture
logger.py(Synchronized with PR #208)Package Structure Enhancement
src/mlflow/__init__.py(Synchronized with PR feat: MLflow 3.1.0 Models-from-Code Migration for Vanilla RAG Blueprint #208): Universal module initialization with generic exportscore.audio_translation_service.audio_translation_servicetosrc.mlflowModelSignaturebuilt and passed toLogger.log_model(signature, ...)Configuration & Environment Changes
NeMo Model Integration
.nemofiles stored inmodels/subdirectory following PR feat: MLflow 3.1.0 Models-from-Code Migration for Vanilla RAG Blueprint #208 patternUniversal Loader/Logger Synchronization
Implementation Details
Architecture Impact
Logger(universal MLflow integration)Model(NeMo-specific audio translation functionality)loader(universal MLflow deployment interface)Code Organization
src/mlflow/package with universal structure synchronized with PR feat: MLflow 3.1.0 Models-from-Code Migration for Vanilla RAG Blueprint #208core/audio_translation_service/blueprint-specific structureModelSignaturecreation + pass toLogger.log_model).nemomodel files in MLflow artifact structureNeMo-Specific Enhancements
Model Pipeline Architecture
GPU Memory Management
ONNX Export Integration
get_onnx_export_config()Universal Synchronization Benefits
Quality Assurance
Code Quality
Performance Impact
Review Guidelines
Critical Review Areas
loader.pyis byte-exact copy from PR feat: MLflow 3.1.0 Models-from-Code Migration for Vanilla RAG Blueprint #208 with universal importsModel.predict()maintains identical signature and behaviorTesting Instructions
notebooks/register-model.ipynbto validate new logging approach with universal structureBreaking Changes
None - This migration maintains complete API compatibility:
Universal Synchronization Details
Shared Implementation Strategy
loader.py: Exact byte-for-byte copy from PR feat: MLflow 3.1.0 Models-from-Code Migration for Vanilla RAG Blueprint #208 ensures identical behaviorlogger.py: Exact byte-for-byte copy from PR feat: MLflow 3.1.0 Models-from-Code Migration for Vanilla RAG Blueprint #208 ensures consistent MLflow integration__init__.py: Exact copy from PR feat: MLflow 3.1.0 Models-from-Code Migration for Vanilla RAG Blueprint #208 with universal export patternNeMo-Specific Considerations
.nemomodel filesFuture Blueprint Migrations
This implementation provides a reusable migration pattern following PR #208 for specialized frameworks:
loader.py,logger.py,__init__.py) from PR feat: MLflow 3.1.0 Models-from-Code Migration for Vanilla RAG Blueprint #208Modelclass following PR feat: MLflow 3.1.0 Models-from-Code Migration for Vanilla RAG Blueprint #208 constructor pattern insrc/mlflow/model.pyfrom src.mlflow import LoggerMigration Status: ✅ Complete with Universal Structure Synchronized with PR #208 and NeMo Integration Ready for Review
This comprehensive architectural migration successfully modernizes the Audio Translation with NeMo blueprint for MLflow 3.1.0 while adopting the universal structure standard and synchronizing shared components with PR #208. The migration preserves all NeMo-specific functionality including GPU acceleration, ONNX export capabilities, and multi-modal audio processing while improving consistency and maintainability across all AI blueprints.
NeMo-Specific Migration Highlights
Advanced Features Preserved
Framework Integration Excellence
.nemomodel files in deployment contextThis migration sets the standard for integrating specialized AI frameworks within the MLflow structure while maintaining full feature compatibility and performance optimization.
Printed page of the Streamlit web app showing evidence of successful local deployment and API testing:
Streamlit for Audio Translation with Nemo.pdf