Skip to content

Allow the default Android app API version to be overwritten by environment variable. #92

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open

Allow the default Android app API version to be overwritten by environment variable. #92

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
54d9ae1
Allow app.api_version overwrite by environment var
khalilgharbaoui Sep 19, 2020
f84bb20
Add note about ANDROID_APP_API_VERSION to readme
khalilgharbaoui Sep 19, 2020
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 7 additions & 0 deletions README.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -43,6 +43,13 @@ If you are targeting Android, you need to install the dependencies with Gradle:
$ bundle && rake android:gradle:install
```

NOTE: The Android app API version defaults to version `"23"`.
To overwrite it set the environment variable `ANDROID_APP_API_VERSION` to the desired version for example:

```
echo 'export ANDROID_APP_API_VERSION="28"' >> ~/.zshrc
```

### Projects

#### Flow projects
Expand Down
2 changes: 1 addition & 1 deletion lib/android.rb
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -5,7 +5,7 @@
require 'motion-gradle'

Motion::Project::App.setup do |app|
app.api_version = '23' unless Motion::Project::Config.starter?
app.api_version = ENV['ANDROID_APP_API_VERSION'] ||= '23' unless Motion::Project::Config.starter?
app.build_dir = 'build/android'
app.assets_dirs << 'resources'
app.resources_dirs = []
Expand Down