Skip to content

Debug test failures #25

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 5 commits into
base: master
Choose a base branch
from
Open

Debug test failures #25

Changes from all commits
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
3880018
Debug test failures
timholy Apr 4, 2022
9a0afe6
Annot more
timholy Apr 4, 2022
60e4eb6
More info
timholy Apr 4, 2022
5dbeec8
Print before
timholy Apr 4, 2022
008d902
Also show fval
timholy Apr 4, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
12 changes: 7 additions & 5 deletions src/RegisterOptimize.jl
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -100,8 +100,8 @@ function optimize_rigid(fixed, moving, A::AffineMap, maxshift,
MathProgBase.optimize!(m)

stat = MathProgBase.status(m)
stat == :Optimal || @warn("Solution was not optimal")
p = MathProgBase.getsolution(m)
stat == :Optimal || (@warn("Solution was not optimal 1"); @show p)
fval = MathProgBase.getobjval(m)

p2rigid(p, SD), fval
Expand Down Expand Up @@ -475,8 +475,9 @@ function find_opt(P::AffineQHessian{AP,M,N,Φ}, b, maxshift, x0) where {AP,M,N,
MathProgBase.setwarmstart!(m, x0)
MathProgBase.optimize!(m)
stat = MathProgBase.status(m)
stat == :Optimal || @warn("Solution was not optimal")
MathProgBase.getsolution(m)
p = MathProgBase.getsolution(m)
stat == :Optimal || (@warn("Solution was not optimal 2"); @show p)
return p
end

# We omit the constant term ∑_i cs[i]'*Qs[i]*cs[i], since it won't
Expand Down Expand Up @@ -604,12 +605,13 @@ function _optimize!(objective, ϕ, dp, mmis, tol, print_level; kwargs...)
MathProgBase.loadproblem!(m, length(uvec), 0, -ub, ub, T[], T[], :Min, objective)
MathProgBase.setwarmstart!(m, uvec)
fval0 = MathProgBase.eval_f(objective, uvec)
@show uvec fval0
isfinite(fval0) || error("Initial value must be finite")
MathProgBase.optimize!(m)

stat = MathProgBase.status(m)
stat == :Optimal || @warn("Solution was not optimal")
uopt = MathProgBase.getsolution(m)
stat == :Optimal || (@warn("Solution was not optimal 3"); @show uopt)
fval = MathProgBase.getobjval(m)
_copy!(ϕ, uopt)
ϕ, fval, fval0
Expand Down Expand Up @@ -1164,8 +1166,8 @@ function fit_sigmoid(data, bottom, top, center, width)
MathProgBase.optimize!(m)

stat = MathProgBase.status(m)
stat == :Optimal || @warn("Solution was not optimal")
x = MathProgBase.getsolution(m)
stat == :Optimal || (@warn("Solution was not optimal 4"); @show x)

x[1], x[2], x[3], x[4], MathProgBase.getobjval(m)
end
Expand Down