standardebooks 2.9.2 (new formula) #234265
Open
+309
−0
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
python
|
Draft as I need to determine which additional python |
unitof
force-pushed
the
add-standardebooks
branch
2 times, most recently
from
b912e98 to
0da5a5a
Compare
unitof
force-pushed
the
add-standardebooks
branch
from
0da5a5a to
4152a5c
Compare
github-actions
bot
added
the
automerge-skip
unitof
force-pushed
the
add-standardebooks
branch
from
4152a5c to
087a9df
Compare
unitof
force-pushed
the
add-standardebooks
branch
from
087a9df to
ecb451b
Compare
unitof
force-pushed
the
add-standardebooks
branch
from
ecb451b to
c794483
Compare
daeho-ro
reviewed
Aug 23, 2025
| depends_on "pillow" | ||
| depends_on "py3cairo" | ||
| depends_on "pycparser" | ||
| depends_on "python-setuptools" |
There was a problem hiding this comment.
python-setuptools formula is used only if it depends on the build, not a python package. So I think we should keep the setuptools as a resource.
| depends_on "openjdk" | ||
| depends_on "pillow" | ||
| depends_on "py3cairo" | ||
| depends_on "pycparser" |
There was a problem hiding this comment.
There is no explicit dependency of pycparser and this is maybe from cffi, so we don't need.
| license "GPL-3.0-or-later" | ||
| head "https://github.com/standardebooks/tools.git", branch: "master" | ||
|
|
||
| depends_on "rust" => :build |
There was a problem hiding this comment.
Need a comment for ex,
Suggested change
| depends_on "rust" => :build | |
| depends_on "rust" => :build # selenium -> setuptools-rust |
| depends_on "py3cairo" | ||
| depends_on "pycparser" | ||
| depends_on "python-setuptools" | ||
| depends_on "[email protected]" |
There was a problem hiding this comment.
Make it up to date.
Suggested change
| depends_on "python@3.12" | |
| depends_on "python@3.13" |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
HOMEBREW_NO_INSTALL_FROM_API=1 brew install --build-from-source <formula>, where<formula>is the name of the formula you're submitting?brew test <formula>, where<formula>is the name of the formula you're submitting?brew audit --strict <formula>(after doingHOMEBREW_NO_INSTALL_FROM_API=1 brew install --build-from-source <formula>)? If this is a new formula, does it passbrew audit --new <formula>?