-
-
Notifications
You must be signed in to change notification settings - Fork 13k
ffmpeg 8.0 #234498
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
ffmpeg 8.0 #234498
Conversation
7ff7148
to
a569a77
Compare
0f47ef4
to
07f6cb1
Compare
07f6cb1
to
4dd4b06
Compare
@@ -19,7 +19,7 @@ class Chromaprint < Formula | |||
end | |||
|
|||
depends_on "cmake" => :build | |||
depends_on "ffmpeg" | |||
depends_on "ffmpeg@7" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can probably stay with latest ffmpeg
with -DCMAKE_POLICY_VERSION_MINIMUM=3.5
.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
cmake minimum has already been bumped to 3.10
in the project's git head: acoustid/chromaprint@6ce6c4d
Prior to that it was bumped to 3.5...3.10
: acoustid/chromaprint@1120d82
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This project has also bumped cmake_minimum_version
in HEAD (to 3.10
): mgba-emu/mgba@e95b81f
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The error here is due to the removal of a deprecated feature in zig build: https://ziglang.org/download/0.15.1/release-notes.html#Removed-Deprecated-Implicit-Root-Module
Amusingly, the zig docs have this exact same failure, apparently inserted by a CI run that shows the output of their example commands: https://ziglang.org/learn/build-system/
/home/ci/actions-runner-website/_work/www.ziglang.org/www.ziglang.org/zig-code/build-system/unit-testing/build.zig:20:14: error: no field named 'root_source_file' in struct 'Build.TestOptions'
EDIT: filed seatedro/glyph#32 upstream for tracking
Created by
brew bump
Created with
brew bump-formula-pr
.